Support determining activity date from default branch #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t recent push activity_method defaults to the current behavior: repo.pushed_at however, I think the most recent commit to the default branch is another valid way of determining staleness/activity. Our organization uses dependabot, which continues to open PRs and push commits to repositories which have not had any human contribution in more than a year. With this change, we will easily be able to surface repositories that otherwise would be missed due to bot activity keeping them "fresh".
zkoppert
reviewed
Feb 1, 2024
zkoppert
reviewed
Feb 1, 2024
|
Thanks for adding this enhancement @anovadox! Appreciate you adding this! |
Co-authored-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
New Staleness criteria: latest default_branch commit
Proposed Changes
Support determining activity date from default branch rather than most recent push to any branch
ACTIVITY_METHODdefaults to the current behavior:repo.pushed_ataka"pushed"However, I think the most recent commit to the default branch (
default_branch_updated) is another valid way of determining staleness/activity.Our organization uses dependabot, which continues to open PRs and push commits to repositories which have not had any human contribution in more than a year.
With this change, we will easily be able to surface repositories that otherwise would be missed due to bot activity keeping them "fresh".
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking