Skip to content
This repository has been archived by the owner on Nov 1, 2017. It is now read-only.

Switch from capybara-webkit to poltergeist #32

Merged
merged 2 commits into from
Sep 5, 2012
Merged

Switch from capybara-webkit to poltergeist #32

merged 2 commits into from
Sep 5, 2012

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Sep 5, 2012

Some people at RubyConfBR recommended checking out poltergeist, which uses PhantomJS, as an alternative to capybara-webkit.

I did, and it seems really awesome. This is all I had to do to make all the tests pass (most of the code is JS, I was impressed).

It doesn't require QT or xvfb, is faster, more stable, and is being actively developed. I don't see a reason not to use it in place of capybara-webkit everywhere.

/cc @github/ops @jonmagic @spicycode

@jnewland
Copy link

jnewland commented Sep 5, 2012

Awesomeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee ❤️

@wfarr
Copy link

wfarr commented Sep 5, 2012

YES YES YES YES YES YES YES YES YES YES YES YES YES YES YES YES YES

I setup Phantom on all the squeeze janky nodes, so CI should just work.

Now if only we could get all the other capybara-webkit projects onto poltergeist!

On Wednesday, September 5, 2012 at 1:35 PM, Jesse Newland wrote:

Awesomeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee


Reply to this email directly or view it on GitHub (#32 (comment)).

bkeepers added a commit that referenced this pull request Sep 5, 2012
Switch from capybara-webkit to poltergeist
@bkeepers bkeepers merged commit d71ed60 into master Sep 5, 2012
@jonmagic
Copy link
Member

jonmagic commented Sep 5, 2012

We'll check it out today.

@rafaelfranca
Copy link

Cool! Love to see our suggestion being used ❤️

@bkeepers
Copy link
Contributor Author

@rafaelfranca Between this and ✂️, you have significantly altered my universe.

@rafaelfranca
Copy link

hahahha. ✂️ is the best emoji ever.

@jmuheim
Copy link

jmuheim commented Nov 15, 2012

We checked it out, but it seems to be a very little bit slower than Capybara-webkit. But our test suite is not very heavy yet, so the results are not very specific.

Is there some more information about speed issues?? Performance tests?

@skalnik
Copy link
Member

skalnik commented Nov 15, 2012

You're not counting the time it takes to compile QT in those performance tests 😉.

In all seriousness though, removing the QT dependency alone is a reason to use poltergeist in my book.

@bkeepers
Copy link
Contributor Author

@sientia-jmu I don't have anything scientific, but it was certainly faster on the few apps I switched. YMMV.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants