-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated cheat sheet (PT) PDF file #326
Comments
Good find! Because the PDF files a bit harder to update, we were thinking of leaning more towards web-only view for these cheat sheets. Is the translation in the |
Good find! Because the PDF files a bit harder to update, we were thinking of leaning more towards web-only view for these cheat sheets.
Sounds good. By the way, if people ask for the PDF files, could they be hosted
somewhere and then use Webhooks to keep them synced?
Is the translation in the `.md` file correct thought?
Actually there are some things I just noticed that could be fixed/improved.
There are some words I'm not happy with, but I couldn't think of a better
translation. It happens that I just found out that there is a [pt-br
version](https://git-scm.com/book/pt-br/v1) of the Pro Git book and they have
good stuff there.
Should I discuss the changes here or go ahead modify it, make a PR and then
someone revises that?
Should it stress that it's Brazilian Portuguese?
Also, I found another bug in the PDF files. The EN version has the following
command:
`$ git config --global color.ui auto`
Enables helpful colorization of command line output
The PT version has the command as well, but the description is the same as the
one used for `user.email`:
`$ git config --global color.ui auto`
Configura o email que você quer ligado as suas transações de commit
However, none of the `.md` files have that command :O
Thanks!
Ps: I just cloned the repo and was reading the master branch.
|
Ideally i'd love it if the printed version of these web pages looked good enough to be thought of as PDF files. Otherwise we'd love to keep the PDFs here. I just currently know we don't have time to put together too many PDFs, very open to others adding it though
I fully encourage you to submit PRs to revise it. Maybe even making a mention at the top of the file somewhere that it's Brazilian Portuguese (as i don't know the difference between types of Portuguese) to just give a notice to the reader.
It does appear that the description to using |
Ideally i'd love it if the printed version of these web pages looked good enough to be thought of as PDF files. Otherwise we'd love to keep the PDFs here. I just currently know we don't have time to put together too many PDFs, very open to others adding it though
Got it.
I fully encourage you to submit PRs to revise it. Maybe even making a mention at the top of the file somewhere that it's Brazilian Portuguese (as i don't know the difference between types of Portuguese) to just give a notice to the reader.
Alright, I'll do that once I have it ready.
It does appear that the description to using `git config --global color.ui auto` is wrong in the `pt` version of the pdf. In fact all of the `.pdf` files list this command, but they're not in the `.md` version. My vote is to remove them from the pdf's completely, as it's a default in modern versions of Git. Great catch!
I agree! Doesn't look like it's necessary.
Thanks!
|
Finally finished what I think can improve the PT cheat sheet: #328
I did not mention this issue there because although I proposed the changes
here, they're not about the same topic. I think I will leave this issue
open until the PDF thing is solved. Or maybe another one should be open to
address all the PDF files.
Thanks!
|
@felipedau i agree this issue should stay open until the problems in the original post are answered. Taking a look at your PR now, thanks! |
Sorry for closing and re-opening.
@felipedau any update on this? I think keeping this open for the one specific piece to fix would be good. |
@brntbeer since I last posted to this issue, the Maybe a new one should be opened to find a general way to make these things build automatically to keep them synced, because it looks like it is done manually, right? I just edited a couple |
I agree that we should close this down and open an issue to at least speculate ways to get .pdfs to automatically get updated, or some alternative. Honestly if there was a "Print" button on the @felipedau would you like to get started on that issue and close this one? |
That's a great idea! I think that most of it can be done just by changing the CSS. It shouldn't be too hard.
Sure. Are there any other resources that would be useful to be available as |
Can I also make an issue to turn all the cheat sheets into The whole website (including those pages) are synced with this repo, right? Or it still has to be built just like the |
@felipedau i think just the cheat sheets or now. We can end up making the subversion migration one into pdf later and kind of continue to iterate on it.
If you mean turn all of the |
@felipedau sorry, i missed this. yes, everything that's at training.github.com/kit is on this repo itself. When we make the changes here (and probably test them locally) the @github/training-teachers would have to merge it into a private repo to get it deployed. |
Sounds good.
I noticed that the Brazilian Portuguese, Chinese and Italian cheat sheet links point to the
In my opion the
Cool! Then it seems that the easiest way to do what we want is doing Finally, I would like to open the following issues:
|
@felipedau thank you for your thoughtful comments. I completely agree with you and would ❤️ to see this level of consistency among these resources. Please feel free to open a PR containing these changes! |
Sorry @crichID I think I was waiting for @brntbeer's confirmation and forgot this issue. Unfortunately I need help to make those changes, so I opened new issues ( #379, #380). This one can finally be closed! |
It's been a while since the PDF file of the Cheat Sheet in Portuguese was built (Jun 9, 2014), but I'm not sure if there is a schedule to build these things. It happens that it does not have the latest version of the md file (Oct 17, 2014).
In the PDF file, one of the descriptions is in Spanish:
In the source file, it is correct though:
That was the only issue I noticed.
Thanks for the kit!
The text was updated successfully, but these errors were encountered: