Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding southgate #78

Merged
merged 3 commits into from Apr 15, 2014
Merged

Adding southgate #78

merged 3 commits into from Apr 15, 2014

Conversation

southgate
Copy link
Contributor

Sprinkle some @southgate on top for the Abril Pro Ruby workshop.

@@ -27,6 +27,9 @@ img {
height: auto !important;
width: 100% !important; }

img.headshot {
max-width: 50%; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanmccullough I just ran a straight-up

$ be sass theme.scss >| theme.css 

Is there another approved manner for processing the theme?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. This should probably be in the README. I'll try to add it soon. _buildscripts/cibuild/scripts/ will regenerate all the stylesheets and get them "ready" for commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, at this point, I haven't provided a easy to use _buildscript for regenerating the stylesheet from the SASS, let alone a compressed/compacted one. Will flag this in a separate issue so the suggestion doesn't slip.

Thanks!

@matthewmccullough
Copy link

💯 ✨ :shipit: !

matthewmccullough pushed a commit that referenced this pull request Apr 15, 2014
@matthewmccullough matthewmccullough merged commit ca0eab4 into master Apr 15, 2014
@matthewmccullough matthewmccullough deleted the adding-southgate branch April 15, 2014 02:59
@matthewmccullough matthewmccullough restored the adding-southgate branch April 15, 2014 02:59
@matthewmccullough
Copy link

Sorry if I shouldn't have merged. Click happy. My bad.

@matthewmccullough matthewmccullough deleted the adding-southgate branch April 15, 2014 02:59
@southgate
Copy link
Contributor Author

No no. Fine by me 😁 Looking forward to the training tomorrow morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants