Skip to content

Commit

Permalink
Provide a maximum node version in package.json
Browse files Browse the repository at this point in the history
As recommended here [1], since the current build for this extension
does not work with Node v18 [2], it would be good to set a maximum
node version until this gets addressed.

So we're updating `engines` here to allow for a maximum version,
which in this case is v17.0.0.

[1]: #1369 (comment)
[2]: #1373
  • Loading branch information
elenatanasoiu committed Jun 1, 2022
1 parent 642f478 commit 8c97b94
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion extensions/ql-vscode/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion extensions/ql-vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"engines": {
"vscode": "^1.59.0",
"node": ">=16.11.25",
"node": "^16.11.25",
"npm": ">=7.20.6"
},
"categories": [
Expand Down

0 comments on commit 8c97b94

Please sign in to comment.