Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ILM Policy from Index is added #102

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

UyumazHakan
Copy link
Contributor

This PR adds command for removing ILM Policy from an index.

es.go Show resolved Hide resolved
@@ -710,6 +710,18 @@ func (c *Client) GetIndices(index string) ([]Index, error) {
return indices, nil
}

// Get a subset of indices including hidden ones
func (c *Client) GetHiddenIndices(index string) ([]Index, error) {
Copy link

@antkaynak antkaynak Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding - what does hidden indices mean here? Why are they hidden ( including ds-ilm-history indices ) 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some indices created by ILM itself. These indices keep metadata about ILM. Users can also create their own hidden indices by setting correct flag during index generation. This will prevent these indices to appear while listing indices without proper flag.

Copy link

@antkaynak antkaynak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! :shipit:

@UyumazHakan UyumazHakan merged commit a99df93 into main Dec 6, 2022
@UyumazHakan UyumazHakan deleted the uyumazhakan/remove-ilm branch December 6, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants