Implements delete index with query parameters #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugodorea
requested changes
Dec 6, 2022
There was a problem hiding this comment.
@UyumazHakan great job on this one and thanks for putting it together! I left some comments for you. Let me know if that makes sense!
UyumazHakan
deleted the
uyumazhakan/add-delete-index-with-query-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a huge index, the default ack timeout is not enough to all nodes acknowledge delete operation. It returns false ack. However, the indices are deleted after a while. This is not useful when we need to know when the index is deleted.
So, I added
DeleteIndexWithQueryParametersto be able to set query parameters such as timeout. With this, developers can increase the timeout to have aacknowledge:truewith higher timeout.