github_repo_open_issues and github_repo_pull_request_count separately
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have a look at this at some point in the next 12 hours and confirm before merging |
fix test
Update go
Update travis go
|
looks like it was a requested feature already: |
|
LGTM - @iamtgray ? |
fix pr count from multiple repos
fix pull request count test
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we needed
github_repo_open_issuesandgithub_repo_pull_request_countseparately, so I added it(GitHub REST API returns all open issues + pull requests count, not issues only, so we have to use the pull requests API to get the PR count and then subtract it to get issues)
please consider merging it upstream in case other people need it
if it's accepted, we can use infinityworks' version rather than maintaining our own
thanks