Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup-debian.yml not able to setup debian but ubuntu instead .. #5

Closed
quabug opened this issue Jan 17, 2019 · 2 comments
Closed

setup-debian.yml not able to setup debian but ubuntu instead .. #5

quabug opened this issue Jan 17, 2019 · 2 comments

Comments

@quabug
Copy link

quabug commented Jan 17, 2019

Debian script should be like this depend on WireGuard doc


- name: Setup WireGuard preference
  command: "printf 'Package: *\nPin: release a=unstable\nPin-Priority: 90\n' > /etc/apt/preferences.d/limit-unstable"
  tags:
    - wg-install

- name: Add WireGuard key
  apt_key:
    keyserver: "keyserver.ubuntu.com"
    id: "8B48AD6246925553"
    state: present
  run_once: true
  tags:
    - wg-install

- name: Add WireGuard repository
  apt_repository:
    repo: "deb http://deb.debian.org/debian/ unstable main"
    state: present
    update_cache: yes
  run_once: true
  tags:
    - wg-install
@githubixx
Copy link
Owner

Well... The naming is indeed wrong 😉 I'll fix it. But the Ansible Galaxy metadata and also the README states that currently the role only supports Ubuntu 18.04 (Bionic) and Archlinux. Maybe it works also with Ubuntu 16.04 but haven't tested it.
Since I don't use Debian and it's not my primary focus if you're willing to test it I can implement the setup for Debian (or just open a PR). Otherwise I'll just fix the naming and close the issue.

ties added a commit to ties/ansible-role-wireguard that referenced this issue Jan 28, 2019
@ties
feat(debian) enable module to work on debian
53555cc 
Add support for Debian based on the documentation in debian wiki
and discussion in [0].

[0]: githubixx#5
ties added a commit to ties/ansible-role-wireguard that referenced this issue Jan 28, 2019
@ties
feat(debian) enable module to work on debian
91978e4 
Add support for Debian based on the documentation in debian wiki
and discussion in [0].

[0]: githubixx#5
ties added a commit to ties/ansible-role-wireguard that referenced this issue Jan 28, 2019
@ties
feat(debian) enable module to work on debian
cbc6e4c 
Add support for Debian based on the documentation in debian wiki
and discussion in [0].

[0]: githubixx#5
@ties ties mentioned this issue Jan 28, 2019
Merged
githubixx pushed a commit that referenced this issue Feb 6, 2019
@ties @githubixx
feat(debian) enable module to work on debian (#6)
3a8d326 
* feat(debian) enable module to work on debian

Add support for Debian based on the documentation in debian wiki
and discussion in [0].

[0]: #5

* remove run_once for debian

* Install kernel headers on debian

There is no equivalent package of linux-headers-generic on debian.
Package installation needs to specify the architecture (i.e. amd64),
which is captured from dpkg output.

* Only use include_tasks to differentiate distributions

Before Archlinux was split out using ansible_os_family. But since
ansible_os_family overlaps for Debian and Ubuntu, two when
statements were used to split out these cases:

  - All arch derivations
  - Debian
  - Ubuntu

New style is cleaner. Arch derivations can still be used by
overiding ansible_distribution in inventory.

* incorporate feedback: move pin file, other changed_when syntax
@githubixx
Copy link
Owner

Fixed with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quabug @githubixx