Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable config when running against a subset of the initial ansible_play_hosts #79

Open
ypid opened this issue Sep 26, 2020 · 3 comments

Comments

@ypid
Copy link
Contributor

ypid commented Sep 26, 2020

The current design is modeled around ansible_play_hosts:

{% for host in ansible_play_hosts %}

This has one very strong downside which is that this role cannot run against one host because then it would remove all of the peers from that one host. I am currently looking into using inventory groups for this like in https://docs.debops.org/en/master/ansible/roles/tinc/index.html as part of #66. I opened this issue here because I think it is relevant for others as well. Note that there are more changes needed to solve this issue than just inventory groups.

A common thing to do is to have a "site" playbook which runs all roles against a server and which can fully deploy it. This is kinda incompatible with this role currently.

Fixed in: https://github.com/ypid/ansible-wireguard/tree/prepare-for-debops

ypid added a commit to ypid/ansible-wireguard that referenced this issue Oct 4, 2020
@lucasteinke
Copy link

@githubixx what's preventing this from being implemented?

@ypid do you want to create a PR at some point or do you want to keep your role separately?

@githubixx
Copy link
Owner

@lucasteinke Mainly time 😉

@ypid
Copy link
Contributor Author

ypid commented Jul 3, 2022

do you want to create a PR at some point or do you want to keep your role separately?

As I was getting into this role, I took care to upstream changes in all areas where our visions aligned. You are welcome to cherry-pick from my fork if you like. The PR will not be done for you @lucasteinke ;-)

Ref: #66 and other tickets for discussion how the fork came to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants