Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reboot to the standard mode #184

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

mofelee
Copy link
Contributor

@mofelee mofelee commented Mar 8, 2023

It needs to be rebooted to make the WireGuard kernel module available.

Copy link
Owner

@githubixx githubixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments inline. Please also update README.md accordingly. Also please add an entry to CHANGELOG.md about what was changed. As this actually changes the behavior of for the CentOS 7 users it makes sense to have a new major version number. So it would be 14.0.0.

tasks/setup-centos-7.yml Outdated Show resolved Hide resolved
tasks/setup-centos-7.yml Outdated Show resolved Hide resolved
@mofelee
Copy link
Contributor Author

mofelee commented Mar 9, 2023

@githubixx
I think it's okay now.

@githubixx
Copy link
Owner

I just did a Molecule deployment without your pull request and it worked without issues. There is also a task that loads the Wireguard kernel module: https://github.com/githubixx/ansible-role-wireguard/blob/master/tasks/main.yml#L23-L34

So at least a fresh CentOS 7 installation works without reboot. Maybe it makes more sense to make the reboot optional because it's not needed in all cases?

@mofelee
Copy link
Contributor Author

mofelee commented Mar 17, 2023

In my case, if I don't reboot CentOS 7, it cannot pass through the 'Enable WireGuard kernel module' task.

> cat /etc/os-release 
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
> uname -a
Linux xx.local 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 29 14:49:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
> cat /etc/centos-release
CentOS Linux release 7.6.1810 (Core)
> lsb_release
LSB Version:	:core-4.1-amd64:core-4.1-noarch

CleanShot 2023-03-17 at 09 24 44@2x

CleanShot 2023-03-17 at 09 27 10@2x

@mofelee
Copy link
Contributor Author

mofelee commented Mar 17, 2023

@githubixx githubixx merged commit c58f736 into githubixx:master Mar 25, 2023
vincentDcmps pushed a commit to vincentDcmps/ansible-role-wireguard that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants