-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reboot to the standard mode #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few comments inline. Please also update README.md
accordingly. Also please add an entry to CHANGELOG.md
about what was changed. As this actually changes the behavior of for the CentOS 7 users it makes sense to have a new major version number. So it would be 14.0.0
.
@githubixx |
I just did a Molecule deployment without your pull request and it worked without issues. There is also a task that loads the Wireguard kernel module: https://github.com/githubixx/ansible-role-wireguard/blob/master/tasks/main.yml#L23-L34 So at least a fresh CentOS 7 installation works without reboot. Maybe it makes more sense to make the reboot optional because it's not needed in all cases? |
In my case, if I don't reboot CentOS 7, it cannot pass through the 'Enable WireGuard kernel module' task. > cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7" > uname -a
Linux xx.local 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 29 14:49:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux > cat /etc/centos-release
CentOS Linux release 7.6.1810 (Core) > lsb_release
LSB Version: :core-4.1-amd64:core-4.1-noarch |
I've reproduced this error on this ISO file. http://bay.uchicago.edu/centos-vault/7.6.1810/isos/x86_64/CentOS-7-x86_64-Minimal-1810.iso |
It needs to be rebooted to make the WireGuard kernel module available.