Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown block breaks for some syntax #65

Open
jaked opened this issue Jul 28, 2022 · 5 comments
Open

Markdown block breaks for some syntax #65

jaked opened this issue Jul 28, 2022 · 5 comments

Comments

@jaked
Copy link
Contributor

jaked commented Jul 28, 2022

MDX is pickier about syntax than GitHub-Flavored Markdown:

  • it doesn't accept unclosed tags, so e.g. unclosed <img> tags are not supported (example, example)
  • "Expected Unicode escape sequence \uXXXX" (example)
@jaked jaked changed the title Markdown block breaks for some syntax (e.g. https://blocks.githubnext.com/api/auth/signin?callbackUrl=http%3A%2F%2Flocalhost%3A8080%2Fsourcegraph%2Fsourcegraph, http://blocks.githubnext.com/preactjs/preact?branch=master&blockKey=githubnext__blocks-examples__overview-block) Markdown block breaks for some syntax Jul 28, 2022
@Wattenberger
Copy link
Contributor

note: this is handled in the new Markdown-edit Block, and we might not need to tackle this if we're replacing the old Markdown Preview Block

@jaked
Copy link
Contributor Author

jaked commented Aug 15, 2022

huh does the new Markdown-edit block use something other than MDX to render pages? I would expect to see the same bug otherwise.

@Wattenberger
Copy link
Contributor

it does! it's just CodeMirror with a bunch of custom plugins and a Markdown parser

@jaked
Copy link
Contributor Author

jaked commented Aug 16, 2022

whoa! gotta read that code

@tattwamasi
Copy link

Not sure if it's the same issue or not, but noted the tables in the examples repo weren't rendering properly in blocks, but were in the normal site.

Screenshot 2023-01-31 at 4 36 20 PM

Screenshot 2023-01-31 at 4 36 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants