Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonfloatable hidden window disappears on drop in empty area #496

Closed
boggi78 opened this issue Mar 20, 2023 · 5 comments
Closed

Nonfloatable hidden window disappears on drop in empty area #496

boggi78 opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels

Comments

@boggi78
Copy link

boggi78 commented Mar 20, 2023

Hello,

thanks for your development, we really like to use it and test all of the possibilities. Unfortunately we experienced a little issue when using the autohide functionality.

Version
Qt 5.13.2
VisualStudio 2017 64 bit
Advanced Docking System 4.0.2

Steps to reproduce

  1. Using demo app "AdvancedDockingSystemDemo"
  2. Clicking "Pin Active Tab" on the "Filesystem 0 (c+ m+ f-)" (-> Window hides itself to buttom)
  3. Clicking the hidden tab brings it to front
  4. Click the title bar and move it somewhere into the application -> don't drop it into a valid docking container, but into an "empty area"

Expected result
Tab is NOT getting a floatable window (due to configuration) and pops back into the previous position (hidden tab).

Actual result
Window disappears.

Can you please help us out?

Best regards,
Micha

Nonfloatable.hidden.window.disappears1.mp4
@githubuser0xFFFF
Copy link
Owner

githubuser0xFFFF commented Mar 21, 2023

Fixed this in master - please test. Do you have a link to the application in which you use ADS? I would like to add it to my showcase section. Maybe you have a screenshot or a link?

@boggi78
Copy link
Author

boggi78 commented Mar 21, 2023

Thank you for your fast response and bugfix.
The problem still persists.
i read your code and the added comment and i think my description was not exactly enough.
Following your comment i would add an additional case:
" Non floatable auto hide widgets should stay in its current auto hide
state if they are dragged into a invalid drop area"
The main part here is the "invalid drop area"

Do you know what i mean?
I will ask somebody in our company for a permission to make some screenshots for your showcase, because it is an internal tool.

@githubuser0xFFFF
Copy link
Owner

githubuser0xFFFF commented Mar 22, 2023

If I test here, I cannot see the issue from the video anymore. If I pin the "Filesystem 0 (c+ m+ f-)" window and try to drag it into a floating window, it stays in the auto hide state.

" Non floatable auto hide widgets should stay in its current auto hide
state if they are dragged into a invalid drop area"

I think this is exactly what I have implemented,

So I do not really understand the problem now. Please post a new video to show the problem.

@boggi78
Copy link
Author

boggi78 commented Mar 22, 2023

ok, sure
here a new recordered session

Nonfloatable.hidden.window.disappears2.mp4

You can see ... i dont drag it into a floating window. i drag it into an invalid area

@boggi78
Copy link
Author

boggi78 commented Apr 10, 2023

Ok.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants