Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade PyQt build #404

Merged

Conversation

luelista
Copy link

Hi,
I'm working on upgrading the build process of the PyQt bindings to the current recommendations of the PyQt-builder / sip authors, so that it works with the current version of sip and pip.

It's currently WIP because I can't build the resources file (ads.qrc) reliably yet. It only works if the build directory is in a subfolder of the main repo, because I had to hardcode the path in the config file (qmake-settings = ["RESOURCES += ../../src/ads.qrc"].

Once I found out the right way to solve this I'll update this PR. I thought I'd still open this already, if you have any feedback regarding this update.

@githubuser0xFFFF
Copy link
Owner

Thank you for your contribution. I cannot help you much, because I have not experience yet with PyQt. Just tell me when you think the pull request is ready and I will merge it.

@luelista luelista force-pushed the feature/upgrade-PyQt-build branch from f953c0d to 0cb13e3 Compare May 2, 2022 19:40
@luelista
Copy link
Author

luelista commented May 2, 2022

I fixed the build problem, no hardcoded path any more :) I'm going to test this on some more platforms, and tell you once it's ready.

@luelista luelista force-pushed the feature/upgrade-PyQt-build branch 3 times, most recently from 43c5aa0 to 184e111 Compare May 2, 2022 20:06
@luelista luelista force-pushed the feature/upgrade-PyQt-build branch from 184e111 to a688585 Compare May 2, 2022 20:07
@githubuser0xFFFF
Copy link
Owner

This sounds great. Thank you very much for your help.

@luelista luelista force-pushed the feature/upgrade-PyQt-build branch from 20fa3a1 to a173fc9 Compare July 8, 2022 15:27
@Zholtikov
Copy link

@luelista Do I understand correctly that when you're done - there will be a PyPi package that can be installed with modern versions of pyqt-sip and pyqt ?
Can you tell me when you plan to finish? I really look forward to these changes...

@luelista
Copy link
Author

luelista commented Jul 19, 2022

@Zholtikov it is already possible to install, I put up a WIP version on PyPI: https://pypi.org/project/PyQtAds/
I compiled binary wheels for macOS, Linux and Windows.
Edit: Modern versions of PyQt5, yes - still no Qt 6 support

@githubuser0xFFFF
I tested it on macOS, Linux and Windows now, and also had some users test it. So I think this PR is ready now.

@luelista luelista changed the title WIP: upgrade PyQt build upgrade PyQt build Jul 19, 2022
@githubuser0xFFFF
Copy link
Owner

Thank you very much for this great contribution,

@githubuser0xFFFF githubuser0xFFFF merged commit d3f5879 into githubuser0xFFFF:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants