refactor: extract sidebar button into component

src/components/Sidebar.test.tsx

@@ -146,50 +146,6 @@ describe('components/Sidebar.tsx', () => {
     );
   });
 
-  it('opens my github issues page', () => {
-    const openExternalLinkMock = jest.spyOn(comms, 'openExternalLink');
-
-    render(
-      <AppContext.Provider
-        value={{
-          isLoggedIn: true,
-          notifications: mockAccountNotifications,
-        }}
-      >
-        <MemoryRouter>
-          <Sidebar />
-        </MemoryRouter>
-      </AppContext.Provider>,
-    );
-    fireEvent.click(screen.getByLabelText('My Issues'));
-    expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
-    expect(openExternalLinkMock).toHaveBeenCalledWith(
-      'https://github.com/issues',
-    );
-  });
-
-  it('opens my github pull requests page', () => {
-    const openExternalLinkMock = jest.spyOn(comms, 'openExternalLink');
-
-    render(
-      <AppContext.Provider
-        value={{
-          isLoggedIn: true,
-          notifications: mockAccountNotifications,
-        }}
-      >
-        <MemoryRouter>
-          <Sidebar />
-        </MemoryRouter>
-      </AppContext.Provider>,
-    );
-    fireEvent.click(screen.getByLabelText('My Pull Requests'));
-    expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
-    expect(openExternalLinkMock).toHaveBeenCalledWith(
-      'https://github.com/pulls',
-    );
-  });
-
   it('should quit the app', () => {
     const quitAppMock = jest.spyOn(comms, 'quitApp');
 

src/components/Sidebar.tsx

@@ -1,8 +1,6 @@
 import {
   BellIcon,
   GearIcon,
-  GitPullRequestIcon,
-  IssueOpenedIcon,
   SyncIcon,
   XCircleIcon,
 } from '@primer/octicons-react';
@@ -11,12 +9,7 @@ import { useLocation, useNavigate } from 'react-router-dom';
 import { Logo } from '../components/Logo';
 import { AppContext } from '../context/App';
 import { quitApp } from '../utils/comms';
-import {
-  openGitHubIssues,
-  openGitHubNotifications,
-  openGitHubPulls,
-  openGitifyRepository,
-} from '../utils/links';
+import { openGitHubNotifications, openGitifyRepository } from '../utils/links';
 import { getNotificationCount } from '../utils/notifications';
 import { SidebarButton } from './buttons/SidebarButton';
 
@@ -63,18 +56,6 @@ export const Sidebar: FC = () => {
           icon={BellIcon}
           onClick={() => openGitHubNotifications()}
         />
-
-        <SidebarButton
-          title="My Issues"
-          icon={IssueOpenedIcon}
-          onClick={() => openGitHubIssues()}
-        />
-
-        <SidebarButton
-          title="My Pull Requests"
-          icon={GitPullRequestIcon}
-          onClick={() => openGitHubPulls()}
-        />
       </div>
 
       <div className="px-3 py-4">

src/utils/links.test.ts

@@ -10,10 +10,8 @@ import * as helpers from './helpers';
 import {
   openAccountProfile,
   openDeveloperSettings,
-  openGitHubIssues,
   openGitHubNotifications,
   openGitHubParticipatingDocs,
-  openGitHubPulls,
   openGitifyReleaseNotes,
   openGitifyRepository,
   openHost,
@@ -52,20 +50,6 @@ describe('utils/links.ts', () => {
     );
   });
 
-  it('openGitHubIssues', () => {
-    openGitHubIssues();
-    expect(comms.openExternalLink).toHaveBeenCalledWith(
-      'https://github.com/issues',
-    );
-  });
-
-  it('openGitHubPulls', () => {
-    openGitHubPulls();
-    expect(comms.openExternalLink).toHaveBeenCalledWith(
-      'https://github.com/pulls',
-    );
-  });
-
   it('openAccountProfile', () => {
     openAccountProfile(mockGitHubCloudAccount);
     expect(comms.openExternalLink).toHaveBeenCalledWith(

src/utils/links.ts

@@ -19,14 +19,6 @@ export function openGitHubNotifications() {
   openExternalLink('https://github.com/notifications' as Link);
 }
 
-export function openGitHubIssues() {
-  openExternalLink('https://github.com/issues' as Link);
-}
-
-export function openGitHubPulls() {
-  openExternalLink('https://github.com/pulls' as Link);
-}
-
 export function openAccountProfile(account: Account) {
   const url = new URL(`https://${account.hostname}`);
   url.pathname = account.user.login;