refactor: create a KBD_SHORTCUT_DEFAULT constant

gitify-app · Apr 17, 2024 · 81ad51f · 81ad51f
1 parent 8bad772
commit 81ad51f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/__mocks__/mock-state.ts b/src/__mocks__/mock-state.ts
@@ -1,4 +1,5 @@
 import { type AuthState, type SettingsState, Theme } from '../types';
+import Constants from '../utils/constants';
 import { mockedEnterpriseAccounts, mockedUser } from './mockedData';
 
 export const mockAccounts: AuthState = {
@@ -18,6 +19,6 @@ export const mockSettings: SettingsState = {
   detailedNotifications: false,
   markAsDoneOnOpen: false,
   showAccountHostname: false,
-  kbdShortcut: 'CmdOrCtrl+Alt+G',
+  kbdShortcut: Constants.KBD_SHORTCUT_DEFAULT,
   kbdShortcutEnabled: false,
 };
diff --git a/src/context/App.test.tsx b/src/context/App.test.tsx
@@ -6,6 +6,7 @@ import { useNotifications } from '../hooks/useNotifications';
 import type { AuthState, SettingsState } from '../types';
 import * as apiRequests from '../utils/api-requests';
 import * as comms from '../utils/comms';
+import Constants from '../utils/constants';
 import * as notifications from '../utils/notifications';
 import * as storage from '../utils/storage';
 import { AppContext, AppProvider } from './App';
@@ -291,7 +292,7 @@ describe('context/App.tsx', () => {
         detailedNotifications: false,
         markAsDoneOnOpen: false,
         showAccountHostname: false,
-        kbdShortcut: 'CmdOrCtrl+Alt+G',
+        kbdShortcut: Constants.KBD_SHORTCUT_DEFAULT,
         kbdShortcutEnabled: false,
       },
     );
@@ -337,7 +338,7 @@ describe('context/App.tsx', () => {
         detailedNotifications: false,
         markAsDoneOnOpen: false,
         showAccountHostname: false,
-        kbdShortcut: 'CmdOrCtrl+Alt+G',
+        kbdShortcut: Constants.KBD_SHORTCUT_DEFAULT,
         kbdShortcutEnabled: false,
       },
     );

diff --git a/src/context/App.tsx b/src/context/App.tsx
@@ -43,7 +43,7 @@ export const defaultSettings: SettingsState = {
   detailedNotifications: false,
   markAsDoneOnOpen: false,
   showAccountHostname: false,
-  kbdShortcut: 'CmdOrCtrl+Alt+G',
+  kbdShortcut: Constants.KBD_SHORTCUT_DEFAULT,
   kbdShortcutEnabled: false,
 };
 

diff --git a/src/utils/constants.ts b/src/utils/constants.ts
@@ -18,6 +18,8 @@ export const Constants = {
   ALLREAD_EMOJIS: ['😉', '🎉', '🐯', '🙈', '🎈', '🎊', '👏', '🎪', '🍝'],
 
   FETCH_INTERVAL: 60000,
+
+  KBD_SHORTCUT_DEFAULT: 'CmdOrCtrl+Alt+G',
 };
 
 export const Errors: Record<ErrorType, GitifyError> = {