Skip to content

Commit

Permalink
build(biome): enable noConsoleLog rule
Browse files Browse the repository at this point in the history
  • Loading branch information
setchy committed Jun 18, 2024
1 parent 83f4da3 commit 91afaef
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"enabled": true,
"rules": {
"recommended": true,
"suspicious": {
"noConsoleLog": "error"
},
"nursery": {
"noUnusedFunctionParameters": "error",
"useDefaultSwitchClause": "error"
Expand Down
2 changes: 2 additions & 0 deletions scripts/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ const notarizeApp = async (context) => {
const shouldNotarize = process.env.NOTARIZE === 'true';

if (!shouldNotarize || !isMacOS) {
// biome-ignore lint/suspicious/noConsoleLog: console.log is used for debugging
console.log(
' • notarizing either should not notarize or not building for macOS',
);
return;
}

// biome-ignore lint/suspicious/noConsoleLog: console.log is used for debugging
console.log(' • notarizing started');

return await notarize({
Expand Down
2 changes: 2 additions & 0 deletions src/utils/auth/migration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export async function migrateAuthenticatedAccounts() {
const existing = loadState();

if (hasAccountsToMigrate(existing.auth)) {
// biome-ignore lint/suspicious/noConsoleLog: console.log is used for debugging
console.log('Commencing authenticated accounts migration');

const migratedAccounts = await convertAccounts(existing.auth);
Expand All @@ -20,6 +21,7 @@ export async function migrateAuthenticatedAccounts() {
auth: { ...existing.auth, accounts: migratedAccounts },
settings: existing.settings,
});
// biome-ignore lint/suspicious/noConsoleLog: console.log is used for debugging
console.log('Authenticated accounts migration complete');
}
}
Expand Down

0 comments on commit 91afaef

Please sign in to comment.