refactor: remove unnecessary logic

gitify-app · May 12, 2024 · c62f9ce · c62f9ce
1 parent 358c0f7
commit c62f9ce
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 65 deletions.
diff --git a/src/__mocks__/mockedData.ts b/src/__mocks__/mockedData.ts
@@ -426,7 +426,6 @@ export const mockedGraphQLResponse: GraphQLSearch<Discussion> = {
     search: {
       nodes: [
         {
-          viewerSubscription: 'SUBSCRIBED',
           title: '1.16.0',
           isAnswered: false,
           stateReason: 'OPEN',
@@ -439,20 +438,6 @@ export const mockedGraphQLResponse: GraphQLSearch<Discussion> = {
           },
           comments: mockDiscussionComments,
         },
-        {
-          viewerSubscription: 'IGNORED',
-          title: '1.16.0',
-          isAnswered: false,
-          stateReason: 'ANSWERED',
-          url: 'https://github.com/gitify-app/notifications-test/discussions/123',
-          author: {
-            login: 'discussion-creator',
-            url: 'https://github.com/discussion-creator',
-            avatar_url: 'https://avatars.githubusercontent.com/u/123456789?v=4',
-            type: 'User',
-          },
-          comments: mockDiscussionComments,
-        },
       ],
     },
   },

diff --git a/src/hooks/useNotifications.test.ts b/src/hooks/useNotifications.test.ts
@@ -319,7 +319,6 @@ describe('hooks/useNotifications.ts', () => {
                 nodes: [
                   {
                     title: 'This is a Discussion.',
-                    viewerSubscription: 'SUBSCRIBED',
                     stateReason: null,
                     isAnswered: true,
                     url: 'https://github.com/gitify-app/notifications-test/discussions/612',

diff --git a/src/typesGitHub.ts b/src/typesGitHub.ts
@@ -59,8 +59,6 @@ export type StateType =
   | IssueStateReasonType
   | PullRequestStateType;
 
-export type ViewerSubscription = 'IGNORED' | 'SUBSCRIBED' | 'UNSUBSCRIBED';
-
 export type CheckSuiteStatus =
   | 'action_required'
   | 'cancelled'
@@ -450,7 +448,6 @@ export interface GraphQLSearch<T> {
 }
 
 export interface Discussion {
-  viewerSubscription: ViewerSubscription;
   title: string;
   stateReason: DiscussionStateType;
   isAnswered: boolean;

diff --git a/src/utils/api/client.ts b/src/utils/api/client.ts
@@ -254,7 +254,7 @@ export async function searchDiscussions(
         notification.repository.full_name,
         notification.subject.title,
       ),
-      firstDiscussions: 5,
+      firstDiscussions: 1,
       lastComments: 1,
       lastReplies: 1,
     },

diff --git a/src/utils/api/graphql/discussions.ts b/src/utils/api/graphql/discussions.ts
@@ -31,7 +31,6 @@ export const QUERY_SEARCH_DISCUSSIONS = gql`
     search(query:$queryStatement, type: DISCUSSION, first: $firstDiscussions) {
       nodes {
         ... on Discussion {
-          viewerSubscription
           title
           stateReason
           isAnswered

diff --git a/src/utils/helpers.ts b/src/utils/helpers.ts
@@ -116,11 +116,7 @@ export async function fetchDiscussion(
   try {
     const response = await searchDiscussions(notification, token);
 
-    const discussions = response.data?.data.search.nodes.filter(
-      (discussion) => discussion.title === notification.subject.title,
-    );
-
-    return discussions[0] ?? null;
+    return response.data?.data.search.nodes[0] ?? null;
   } catch (err) {}
 }
 

diff --git a/src/utils/subject.test.ts b/src/utils/subject.test.ts
@@ -12,7 +12,6 @@ import type {
   DiscussionStateType,
   Notification,
   Repository,
-  ViewerSubscription,
 } from '../typesGitHub';
 import {
   getCheckSuiteAttributes,
@@ -239,7 +238,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', null, true)],
+                nodes: [mockDiscussionNode(null, true)],
               },
             },
           });
@@ -266,7 +265,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', 'DUPLICATE', false)],
+                nodes: [mockDiscussionNode('DUPLICATE', false)],
               },
             },
           });
@@ -293,7 +292,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', null, false)],
+                nodes: [mockDiscussionNode(null, false)],
               },
             },
           });
@@ -320,7 +319,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', 'OUTDATED', false)],
+                nodes: [mockDiscussionNode('OUTDATED', false)],
               },
             },
           });
@@ -347,7 +346,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', 'REOPENED', false)],
+                nodes: [mockDiscussionNode('REOPENED', false)],
               },
             },
           });
@@ -374,7 +373,7 @@ describe('utils/subject.ts', () => {
           .reply(200, {
             data: {
               search: {
-                nodes: [mockDiscussionNode('SUBSCRIBED', 'RESOLVED', true)],
+                nodes: [mockDiscussionNode('RESOLVED', true)],
               },
             },
           });
@@ -394,36 +393,6 @@ describe('utils/subject.ts', () => {
           },
         });
       });
-
-      it('filtered response by subscribed', async () => {
-        nock('https://api.github.com')
-          .post('/graphql')
-          .reply(200, {
-            data: {
-              search: {
-                nodes: [
-                  mockDiscussionNode('SUBSCRIBED', null, false),
-                  mockDiscussionNode('IGNORED', null, true),
-                ],
-              },
-            },
-          });
-
-        const result = await getGitifySubjectDetails(
-          mockNotification,
-          mockAccounts.token,
-        );
-
-        expect(result).toEqual({
-          state: 'OPEN',
-          user: {
-            login: mockDiscussionAuthor.login,
-            html_url: mockDiscussionAuthor.url,
-            avatar_url: mockDiscussionAuthor.avatar_url,
-            type: mockDiscussionAuthor.type,
-          },
-        });
-      });
     });
 
     describe('Issues', () => {
@@ -1176,14 +1145,12 @@ describe('utils/subject.ts', () => {
 });
 
 function mockDiscussionNode(
-  subscription: ViewerSubscription,
   state: DiscussionStateType,
   isAnswered: boolean,
 ): Discussion {
   return {
     title: 'This is a mocked discussion',
     url: 'https://github.com/gitify-app/notifications-test/discussions/1',
-    viewerSubscription: subscription,
     stateReason: state,
     isAnswered: isAnswered,
     author: mockDiscussionAuthor,