No New notifications after update to 4.4

[eMerzh]

🔍 Is there already an issue for your problem?

• I have checked older issues, open and closed

📝 Description

Hey 👋

thanks for updating this app 🚀

it seems that me and a few others have issues to retrieve new notifications.

i relogged, restart.. doesn't seems to help

🪜 Steps To Reproduce

1. start app
2. get notification
3. nothing happens

ℹ System Info

Mac 13.5.2 (22G91) 
latest 4.4.0

📸 Screenshots

No response

[afonsojramos]

Do you have notifications enabled for the app on MacOS?

[kpurdon]

As a data point, installed the previous version and all notifications immediately came through.

[eMerzh]

oh sorry that wasn't clear ... i meant github notifications 😬 ....
funnyliy enough i got at notif for this one .... now that i try to redo that i can't...

if you want a screenshot :

[AlexanderHieser]

I have the same problem. Going back to v4.3.1 solved the issue.

[afonsojramos]

@kpurdon @eMerzh @AlexanderHieser can you try to disable colors? I have a suspicion... Also, did you login with GitHub or using a token? If with a token, with which scopes?

[eMerzh]

@afonsojramos hum ... it seems to be related to colors indeed
(but i like colors 🥺)

note: i need to quit/restart to apply the setting (on or off)

ftr I used the token to login...

[afonsojramos]

I think that for the colors it may require the repo scope, which the previous version did not have. The repo scope was introduced here: #538
I'll try to take a look if there is something that can be done.

[dberuben]

same issue

[cleardemon]

Hi there, just wanted to give confirmation that either disabling colours or updating the token with repo scope makes notifications appear in Gitify again in 4.4.

[ponkio-o]

Hi, I'm having the same problem with Github Enterprise Server. I tried repo scope permission granted but it didn't show up.
Does anyone else have a similar problem??

[rbclark]

I ended up having to log out and log back in which fixed things for me. After the re-auth I received the following email from Github:

Previously, a third-party OAuth application (Gitify) had notifications and read:user scopes. It was recently granted an additional scope (repo).

Potentially related? #606

[bmulholland]

@rbclark Yes, you got it, see #624 (comment)

Unfortunately we don't have a flow to request updated scopes, and doing that would be a bunch of work. We could add a fallback to not use colors, though that also wouldn't be great. I think that's the only two options? Dropping colors doesn't make sense, it's a nice feature.

[rbclark]

@bmulholland I think the most clear thing would be logging out the user if they don't have the proper scopes and requiring them to re-authenticate. It took me the whole week of not getting notifications before I investigated since I didn't realize anything was wrong since it was silently failing.

[bmulholland]

Yeah that's an easy enough idea. @afonsojramos what do you think?

[bmulholland]

Okay I'm still learning the codebase so that solution needs a bit more understanding than I can quickly do. I've instead created #660 to default the colors to off, and flag in the settings that re-auth is needed, until we can apply that.

The PR could use a little extra help, if anyone has 30 minutes for straightforward test fixes.

[kusold]

🐛 Using a Github Enterprise instance with a PAT that has notifications, read:user, repo scopes, Gitify does not work with colors enabled. If I disable colors and restart the app, it begins working again.

There might be an additional edge case that only applies to GHE instances.

Side Note: It's exciting to see new releases of this app. Thanks for all the hard work.

[afonsojramos]

@kusold this is an edge case that has already been fixed. Maybe it is worth it to do another release.

[brunogeronimo]

Hey 🙂,
As a user feedback, it would be great not to force users to grant repo permission, since the app works perfectly fine just with notifications scope, even though we lose support for colors in this case.

Some companies using GitHub Enterprise for example might be picky in terms of being OK with granting repo and other permissions on the token, specially if the app works just fine without any of them.

[FranCarstens]

@brunogeronimo, 4.4.0 works for me when creating a new access token without the "repo" permission, and "use colors" unchecked.

[brunogeronimo]

Hey @FranCarstens 🙂
To me it also works, but one of the suggestions proposed in this thread was to log the user out to ask for the missing access (here).

I just wanted to share some feedback that it might force some users not to use Gitify anymore.

[bmulholland]

@brunogeronimo We're not logging users out. See #673

It's been a bit slow coming, we've both got other stuff going on, thanks for all your patience.