feat: improve enterprise login #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashiro
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
setchy
requested changes
May 14, 2024
setchy
reviewed
May 14, 2024
setchy
added
the
enhancement
setchy
reviewed
May 14, 2024
setchy
reviewed
May 14, 2024
setchy
reviewed
May 14, 2024
|
thank for your patience @mashiro. fyi - i'll push an update to this feature branch shortly to help move this enhancement along. watch this space 😃 |
|
Updates pushed. @mashiro @afonsojramos - appreciate some feedback. the Settings changes now support logging in with pat, or logging in with oauth app, after the initial login. it is still constrained to at-most one of each. in v5.7.x we'll focus on adding account views and a new account type model to support adding any number of each. 💪 |
|
@setchy Looks good! |
setchy
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following issues with GitHub Enterprise.
Multiple logins to github enterprise are now possible with a personal token and the github app.planned to 5.7.x