-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve enterprise login #1112
Conversation
thank for your patience @mashiro. fyi - i'll push an update to this feature branch shortly to help move this enhancement along. watch this space 😃 |
Updates pushed. @mashiro @afonsojramos - appreciate some feedback. the Settings changes now support logging in with pat, or logging in with oauth app, after the initial login. it is still constrained to at-most one of each. in v5.7.x we'll focus on adding account views and a new account type model to support adding any number of each. 💪 |
@setchy Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mashiro ❤️
Fixed the following issues with GitHub Enterprise.
Multiple logins to github enterprise are now possible with a personal token and the github app.planned to 5.7.x