Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new account management view #1172

Merged
merged 16 commits into from
Jun 6, 2024
Merged

feat: new account management view #1172

merged 16 commits into from
Jun 6, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 3, 2024

Add new Accounts view for managing authenticated accounts

  • accessible via the Sidebar via the Person icon
  • the Login with <x> buttons have been moved from Settings view to the new Accounts view
  • the Logout (from all accounts) remains under Settings

Feedback appreciated on the UI - happy to iterate on it now, or in future.
Screenshot 2024-06-03 at 9 04 13 PM

Example of what it would look like when authenticated with multiple accounts

Screenshot 2024-06-03 at 3 12 32 PM

Note: I have still left the restriction on only 1 of each auth method as to relax this restriction require changes to our AccountNotification key and interaction methods (mark repo as read, native notifications, etc)

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 3, 2024
@setchy setchy added this to the Release 5.7.0 milestone Jun 3, 2024
@setchy setchy marked this pull request as ready for review June 3, 2024 19:24
@afonsojramos
Copy link
Member

Looks really cool! Awesome actually! One thing I'd change is to only show the icon in the sidebar in case there are multiple accounts already, what do you think?

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

Looks really cool! Awesome actually!

Thanks mate - appreciate it🙇. Been a bit of a journey to get to this point, but it's all starting to fall into place nicely

One thing I'd change is to only show the icon in the sidebar in case there are multiple accounts already, what do you think?

I moved the add additional accounts buttons into this new Account view as I felt they went together well. I was unclear about the "nuke all accounts logout" and only left that in the existing Settings view. How do you feel about that?

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

One possible suggestion...we could decide to move the Account Management button into the Settings footer, in place of where the "add extra accounts" buttons currently are... It would leave the sidebar as-is (win), but, does add another layer of settings mgmt depth 🤷‍♂️

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

One possible suggestion...we could decide to move the Account Management button into the Settings footer, in place of where the "add extra accounts" buttons currently are... It would leave the sidebar as-is (win), but, does add another layer of settings mgmt depth 🤷‍♂️

decided to go down this route... branch updated :)

@afonsojramos
Copy link
Member

@setchy Looking good! How about we remove the "master" Logout? 🧐

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

@setchy Looking good! How about we remove the "master" Logout? 🧐

Good callout. Done 🧹 🧼

Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good to my eyes. Really nice work in all the steps getting here, too. Great stuff!

Coverage decreased (-0.07%) to 96.904%

So demanding! Not an issue for me.

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

Coverage decreased (-0.07%) to 96.904%

So demanding! Not an issue for me.

Coveralls really has no chill haha. It dropped when removing the master logout.

96+% coverage is still a mighty stat to be proud of

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Excited to see this live!

@setchy setchy merged commit 40d3104 into main Jun 6, 2024
6 of 7 checks passed
@setchy setchy deleted the feature/accounts-view branch June 6, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants