Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: notification type icon size #1251

Merged
merged 4 commits into from
Jun 16, 2024
Merged

Conversation

afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented Jun 16, 2024

Notification type icon was a bit too big from the information architecture perspective, so I reduced it to the size of the rest of the icons.

Before
image

After
image

Note: After includes fixes from other PRs.

@setchy
Copy link
Member

setchy commented Jun 16, 2024

I kinda liked that the notification type icon was larger 😄

@setchy setchy added this to the Release 5.9.0 milestone Jun 16, 2024
@setchy setchy added enhancement New feature or enhancement to existing functionality refactor Refactoring of existing feature and removed enhancement New feature or enhancement to existing functionality labels Jun 16, 2024
@setchy setchy merged commit e671125 into main Jun 16, 2024
8 checks passed
@setchy setchy deleted the style/notification-type-size branch June 16, 2024 22:21
@bmulholland
Copy link
Collaborator

bmulholland commented Jun 17, 2024

Thanks for thinking about -- and acting on! -- the information hierarchy!

@afonsojramos
Copy link
Member Author

Thanks for thinking about -- and acting on! -- the information hierarchy!

I live with a designer 👀, so I always try to squeeze more opinions about Gitify out of her! 🎨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants