-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom scrollbars #1253
feat: custom scrollbars #1253
Conversation
thanks @Araxeus 👏 would you mind adding a screenshot for light and dark mode 🙏
What do you think about adding it into |
Looks really nice! Do you think it's worth making the |
just pushed a fix to our |
note: `html::-webkit-scrollbar` is used because a top level `::-webkit-scrollbar` would override the `html.dark::-webkit-scrollbar` style even with `!important`
note: which is a bit sad because it makes the css longer but I don't see a better way to do it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me. Keen to hear what the others think before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome to me! Always prefer custom scrollbars 😁
Closes #1244
Colors could be lighter, and im not sure if raw css is your preferred way of dealing with this, thoughts?