Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: functions over arrow fns #1264

Merged
merged 3 commits into from
Jun 18, 2024
Merged

refactor: functions over arrow fns #1264

merged 3 commits into from
Jun 18, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 18, 2024

convert several arrow fns to regular fns to code consistency

@setchy setchy added the refactor Refactoring of existing feature label Jun 18, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 18, 2024
@setchy setchy marked this pull request as draft June 18, 2024 10:57
@setchy setchy marked this pull request as ready for review June 18, 2024 10:58
bmulholland
bmulholland approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a biome rule or something to enforce this? Otherwise it'll drift again over time :)

@setchy setchy merged commit 27a13e3 into main Jun 18, 2024
8 checks passed
@setchy setchy deleted the refactor/functions branch June 18, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@setchy @bmulholland