Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification filters #1304

Merged
merged 22 commits into from
Jul 2, 2024
Merged

feat: notification filters #1304

merged 22 commits into from
Jul 2, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 21, 2024

New Filter sidebar route which contains any post filtering controls, including

Screenshot 2024-06-21 at 10 39 42 AM

When any non-default filters are selected, it will show a visual indicator
Screenshot 2024-06-21 at 10 40 24 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 21, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 21, 2024
src/routes/Filters.test.tsx Outdated Show resolved Hide resolved
@bmulholland
Copy link
Collaborator

I guess the settings store doesn't support storing arrays?

@setchy
Copy link
Member Author

setchy commented Jun 25, 2024

I guess the settings store doesn't support storing arrays?

it can with a bit of work 😅. give me a few minutes to tinker with that

@setchy
Copy link
Member Author

setchy commented Jun 25, 2024

I guess the settings store doesn't support storing arrays?

updated to use an array Reason[] instead of a nasty string 🙈

Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the extra work to make it an array was worth it :)

@setchy
Copy link
Member Author

setchy commented Jun 25, 2024

Thanks! I think the extra work to make it an array was worth it :)

100000%

@setchy
Copy link
Member Author

setchy commented Jun 25, 2024

@afonsojramos - looking forward to your feedback on this, too, before I merge

@setchy setchy mentioned this pull request Jun 27, 2024
1 task
@setchy setchy changed the title feat: new filters route feat: notification filters Jun 27, 2024
@setchy
Copy link
Member Author

setchy commented Jun 28, 2024

small update... changed the reset to default filters to match other footer styling

Screenshot 2024-06-28 at 8 18 55 AM

@bmulholland
Copy link
Collaborator

FWIW, in that last screenshot, there's no explanation text... I was looking for it and it still look me a minute to find the icon. Without the context, I'd never have guessed that's what the button does!

@setchy
Copy link
Member Author

setchy commented Jul 1, 2024

Even with the hover text? 🤔

@afonsojramos
Copy link
Member

What about adding a counter to the filter icon on the sidebar that when hovered showed a tooltip with the filters being used which could be individually removed AND cleared?

src/routes/Filters.tsx Outdated Show resolved Hide resolved
@setchy setchy marked this pull request as draft July 2, 2024 16:44
@setchy setchy marked this pull request as ready for review July 2, 2024 16:49
@setchy
Copy link
Member Author

setchy commented Jul 2, 2024

Updated to use Clear filters

Screenshot 2024-07-02 at 8 42 09 AM

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!! 🚀 Excited for the next release 👀

@afonsojramos afonsojramos merged commit 9d4720d into main Jul 2, 2024
8 checks passed
@afonsojramos afonsojramos deleted the feat/filters branch July 2, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for simple reason filtering
3 participants