Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract state notification logic #845

Merged
merged 3 commits into from Mar 1, 2024
Merged

refactor: extract state notification logic #845

merged 3 commits into from Mar 1, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 29, 2024 •
edited

Closes: #829

Extracts the notification state logic into it's own file. Also refactored the test suite to be clearer on the scenarios being tested

@setchy setchy marked this pull request as draft February 29, 2024 20:54
@setchy setchy marked this pull request as ready for review March 1, 2024 13:21
bmulholland
bmulholland approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is pretty much just moved code, not any functional changes. Approving on that basis -- I haven't reviewed each individual line. If there are functionality changes too, please point them out so I can take a closer look.

@setchy
Copy link
Member Author

setchy commented Mar 1, 2024

I'm assuming this is pretty much just moved code, not any functional changes. Approving on that basis -- I haven't reviewed each individual line. If there are functionality changes too, please point them out so I can take a closer look.

that's correct, pretty much just moved across.

@setchy setchy merged commit ac23cfd into gitify-app:main Mar 1, 2024
9 checks passed
@setchy setchy deleted the refactor/extract-state-logic branch March 1, 2024 15:18
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy @adufr
refactor: extract state notification logic (gitify-app#845)
c3c4a7d 
* refactor: extract state notification logic

* refactor tests
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor state logic within useNotifications
2 participants
@setchy @bmulholland