Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use regex to extract workflow-run attributes #850

Merged
merged 1 commit into from Mar 3, 2024
Merged

feat: use regex to extract workflow-run attributes #850

merged 1 commit into from Mar 3, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 3, 2024

Use regex to match workflow run titles and extract attributes. Will support #526

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 3, 2024
afonsojramos
afonsojramos approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use GitHub to handle deployments, so I've actually never seen this type of notification, but code wise everything looks good!

@setchy
Copy link
Member Author

setchy commented Mar 3, 2024

I don't use GitHub to handle deployments, so I've actually never seen this type of notification, but code wise everything looks good!

Me either! I created it in my sandbox - https://github.com/setchy/gitify-notifications-sandbox/actions/workflows/waiting.yml

If/as we see other formats of WorkflowRun notifications, we can add support then.

@setchy setchy merged commit 1653666 into gitify-app:main Mar 3, 2024
7 checks passed
@setchy setchy deleted the feature/workflowrun-regex branch March 18, 2024 15:02
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy @adufr
feat: use regex to extract workflow-run attributes (gitify-app#850)
d7d9780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@setchy @afonsojramos