Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: default to repo url #967

Merged
merged 1 commit into from
Apr 6, 2024
Merged

refactor: default to repo url #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export async function generateGitHubWebUrl(
notification: Notification,
accounts: AuthState,
): Promise<string> {
let url: string;
let url = notification.repository.html_url;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is a bit of a messy situation, because the default case made more sense, but obviously it doesn't always enter that conditional... Nice bug find!

const token = getTokenForHost(notification.hostname, accounts);

if (notification.subject.latest_comment_url) {
Expand All @@ -275,7 +275,6 @@ export async function generateGitHubWebUrl(
url = getWorkflowRunUrl(notification);
break;
default:
url = notification.repository.html_url;
break;
}
}
Expand Down