Names a ViewsWithPullRequests type

gitkraken · Oct 31, 2021 · 4a4dc24 · 4a4dc24
1 parent 44f1abe
commit 4a4dc24
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/views/nodes/pullRequestNode.ts b/src/views/nodes/pullRequestNode.ts
@@ -3,25 +3,18 @@ import { ThemeColor, ThemeIcon, TreeItem, TreeItemCollapsibleState } from 'vscod
 import { Colors } from '../../constants';
 import { GitBranch, GitCommit, PullRequest, PullRequestState } from '../../git/git';
 import { GitUri } from '../../git/gitUri';
-import { BranchesView } from '../branchesView';
-import { CommitsView } from '../commitsView';
-import { ContributorsView } from '../contributorsView';
-import { RemotesView } from '../remotesView';
-import { RepositoriesView } from '../repositoriesView';
-import { SearchAndCompareView } from '../searchAndCompareView';
+import { ViewsWithPullRequests } from '../viewBase';
 import { RepositoryNode } from './repositoryNode';
 import { ContextValues, ViewNode } from './viewNode';
 
-export class PullRequestNode extends ViewNode<
-	BranchesView | CommitsView | ContributorsView | RemotesView | RepositoriesView | SearchAndCompareView
-> {
+export class PullRequestNode extends ViewNode<ViewsWithPullRequests> {
 	static key = ':pullrequest';
 	static getId(repoPath: string, id: string, ref: string): string {
 		return `${RepositoryNode.getId(repoPath)}${this.key}(${id}):${ref}`;
 	}
 
 	constructor(
-		view: BranchesView | CommitsView | ContributorsView | RemotesView | RepositoriesView | SearchAndCompareView,
+		view: ViewsWithPullRequests,
 		parent: ViewNode,
 		public readonly pullRequest: PullRequest,
 		public readonly branchOrCommit: GitBranch | GitCommit,

diff --git a/src/views/viewBase.ts b/src/views/viewBase.ts
@@ -66,6 +66,13 @@ export type ViewsWithCommits =
 	| RepositoriesView
 	| SearchAndCompareView
 	| TagsView;
+export type ViewsWithPullRequests =
+	| BranchesView
+	| CommitsView
+	| ContributorsView
+	| RemotesView
+	| RepositoriesView
+	| SearchAndCompareView;
 
 export interface TreeViewNodeCollapsibleStateChangeEvent<T> extends TreeViewExpansionEvent<T> {
 	state: TreeItemCollapsibleState;