Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support replacing mirror/replica domain with main domain for remote provider #1902

Closed
adambadura opened this issue Mar 14, 2022 · 3 comments · Fixed by #1954
Closed

Support replacing mirror/replica domain with main domain for remote provider #1902

adambadura opened this issue Mar 14, 2022 · 3 comments · Fixed by #1954
Assignees
@eamodio
Labels
feature New feature or request needs-verification Request for verification
Milestone
12.1

Comments

@adambadura
Copy link

In our setup with Gerrit (however, I believe this may apply to other types as well) there is one main domain and many local replicas. The replicas are used for fetching, the main one is used for pushing and other Gerrit operations (including REST API, review query, etc.)

It seems however GitLens doesn't support such an approach. Instead, it keeps using the fetch remote to form the Gerrit Id: links. Moreover, due to issue #1787 even the mirror domain is broken.
@adambadura adambadura added feature New feature or request triage Needs to be looked at labels Mar 14, 2022
@felipecrs felipecrs mentioned this issue Apr 7, 2022
Merged
7 tasks
@felipecrs
Copy link
Contributor

#1954 aims to solve this issue.

@adambadura
Copy link
Author

To complete the analysis from #1954, with the setup of the main server and mirrors GitLens configuration should mention only the main server - the one used for pushing.

@eamodio eamodio removed the triage Needs to be looked at label Apr 13, 2022
@eamodio eamodio self-assigned this Apr 13, 2022
@eamodio eamodio added this to the Soon™ milestone Apr 13, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Apr 13, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@eamodio eamodio modified the milestones: Soon™, June 2022 May 16, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature New feature or request needs-verification Request for verification
Projects
None yet
Milestone
12.1
Development

Successfully merging a pull request may close this issue.

Adds support for vanilla Gerrit felipecrs/vscode-gitlens
3 participants
@eamodio @adambadura @felipecrs