Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab remote provider uses legacy routes #2021

Closed
Brcrwilliams opened this issue Jun 2, 2022 · 1 comment
Closed

GitLab remote provider uses legacy routes #2021

Brcrwilliams opened this issue Jun 2, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Brcrwilliams
Copy link
Contributor

Brcrwilliams commented Jun 2, 2022

GitLens uses legacy project routes for GitLab:

  • ${projectURL}/branches
  • ${projectURL}/tree/${branch}
  • ${projectURL}/commit/${sha}
  • ${projectURL}/compare/${base}${notation}${compare}
  • ${projectURL}/blob/${ref}/${fileName}

This routes are all deprecated and scheduled for removal. See these references:

They should be replaced with the following:

  • ${projectURL}/-/branches
  • ${projectURL}/-/tree/${branch}
  • ${projectURL}/-/commit/${sha}
  • ${projectURL}/-/compare/${base}${notation}${compare}
  • ${projectURL}/-/blob/${ref}/${fileName}

Version info:

  • GitLens Version: v12.0.7
  • Git Version: N/A
  • VSCode Version: N/A
  • OS Version: N/A
@Brcrwilliams Brcrwilliams added potential-bug triage Needs to be looked at labels Jun 2, 2022
Brcrwilliams added a commit to Brcrwilliams/vscode-gitlens that referenced this issue Jun 2, 2022
GitLens uses legacy project routes for GitLab:

- `${projectURL}/branches`
- `${projectURL}/tree/${branch}`
- `${projectURL}/commit/${sha}`
- `${projectURL}/compare/${base}${notation}${compare}`
- `${projectURL}/blob/${ref}/${fileName}`

These routes are all deprecated and scheduled for removal. See these references:

- https://docs.gitlab.com/ee/development/routing.html#project-routes
- https://gitlab.com/gitlab-org/gitlab/-/issues/118849
- https://gitlab.com/gitlab-org/gitlab/-/issues/28848

This change replaces them with the following scoped routes:

- `${projectURL}/-/branches`
- `${projectURL}/-/tree/${branch}`
- `${projectURL}/-/commit/${sha}`
- `${projectURL}/-/compare/${base}${notation}${compare}`
- `${projectURL}/-/blob/${ref}/${fileName}`
@eamodio eamodio closed this as completed in 8323ae4 Jun 9, 2022
@eamodio eamodio self-assigned this Jun 9, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Jun 9, 2022
@eamodio eamodio added this to the 12.1 milestone Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants