Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search & Compare quickpick shouldn't select the mode text when opening #2136

Closed
MohanVallivedu opened this issue Aug 4, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@MohanVallivedu
Copy link

Type: Feature Request

Hello team,
In the 'Source Control' section, when we go to SEARCH & COMPARE tile. and select any one of the options (Search for commits by 'message', 'author', etc..), it will open a dialog with text highlighted as "author: ". If we type something, it will replace the tag "author: " to our text which is not good.

image

image

It would be good if the tag text is not highlighted/selected, so that we can start writing our text without removing the tag.
Thanks!

GitLens: v12.1.2
VS Code
Version: 1.70.0 (system setup)
Commit: da76f93349a72022ca4670c1b84860304616aaa2
Date: 2022-08-04T04:38:16.462Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.19044

@MohanVallivedu MohanVallivedu added feature New feature or request triage Needs to be looked at labels Aug 4, 2022
@eamodio eamodio added bug Something isn't working and removed feature New feature or request triage Needs to be looked at labels Aug 7, 2022
@eamodio eamodio self-assigned this Aug 7, 2022
@eamodio eamodio added this to the 12.2 milestone Aug 7, 2022
@eamodio eamodio changed the title Search & Compare feature request Search & Compare quickpick shouldn't select the mode text when opening Aug 7, 2022
@eamodio eamodio closed this as completed in 97f6487 Aug 7, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Aug 7, 2022
@eamodio
Copy link
Member

eamodio commented Aug 7, 2022

This one was trickier than I thought because VS Code doesn't let extensions control the selection in the quick picks (what that popup is called), but I found a workaround (setting the input text before the quick pick is shown causes VS Code to select the text, while updating the text after its shown leave it unselected.

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@MohanVallivedu
Copy link
Author

It is working well. Thank you for your quick response and the fix :)

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Aug 8, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

2 participants