Gerrit: parse change-ids in the whole message body, not only in the footer

[felipecrs]

In Gerrit commit messages, you can include as many change ids as you want. Gerrit's UI will add a hyperlink to each change id found. See:

However, Gitlens currently only parses the last one, in the footer:

PS: I'm working on a PR. Edit: not anymore.

[eamodio]

TY

[felipecrs]

Sorry, @eamodio, I wrongly assumed that Gitlens supported some kind of regex-based autolinks reference, but unfortunately it does not as of now.

It has been previously suggested/reported:

• Make autolinks more sophisticated #1903
• Regular expressions in autolinks #1314
• Bugtraq Support For Issue Trackers #1121 (kind of)

So, I can say that this depends on that to be implemented first.

---

This is to say: please don't expect a PR from me in the short-term anymore. If anyone else wants to work on this issue (or the referenced issues), feel totally free.

[felipecrs]

@eamodio actually here is the PR: #2255, I just need a little bit of help to finish it.

[eamodio]

@felipecrs thanks -- I haven't had a chance to look at that PR yet as we are focused on getting GitLens 13 out early next week. But I did want to mention that built-in remote providers can provide their own tokenization/parsing for autolinks, see

vscode-gitlens/src/git/remotes/github.ts

Lines 56 to 122 in 6db29c1

	override get autolinks(): (AutolinkReference | DynamicAutolinkReference)[] {
	if (this._autolinks === undefined) {
	this._autolinks = [
	{
	prefix: '#',
	url: `${this.baseUrl}/issues/<num>`,
	title: `Open Issue or Pull Request #<num> on ${this.name}`,
	description: `Issue or Pull Request #<num> on ${this.name}`,
	},
	{
	prefix: 'gh-',
	url: `${this.baseUrl}/issues/<num>`,
	title: `Open Issue or Pull Request #<num> on ${this.name}`,
	ignoreCase: true,
	description: `Issue or Pull Request #<num> on ${this.name}`,
	},
	{
	tokenize: (
	text: string,
	outputFormat: 'html' | 'markdown' | 'plaintext',
	tokenMapping: Map<string, string>,
	) => {
	return outputFormat === 'plaintext'
	? text
	: text.replace(autolinkFullIssuesRegex, (linkText: string, repo: string, num: string) => {
	const url = encodeUrl(`${this.protocol}://${this.domain}/${repo}/issues/${num}`);
	const title = ` "Open Issue or Pull Request #${num} from ${repo} on ${this.name}"`;
	const token = `\x00${tokenMapping.size}\x00`;
	if (outputFormat === 'markdown') {
	tokenMapping.set(token, `[${linkText}](${url}${title})`);
	} else if (outputFormat === 'html') {
	tokenMapping.set(token, `<a href="${url}" title=${title}>${linkText}</a>`);
	}
	return token;
	});
	},
	parse: (text: string, autolinks: Map<string, Autolink>) => {
	let repo: string;
	let num: string;
	let match;
	do {
	match = autolinkFullIssuesRegex.exec(text);
	if (match?.groups == null) break;
	({ repo, num } = match.groups);
	autolinks.set(num, {
	provider: this,
	id: num,
	prefix: `${repo}#`,
	url: `${this.protocol}://${this.domain}/${repo}/issues/${num}`,
	title: `Open Issue or Pull Request #<num> from ${repo} on ${this.name}`,
	description: `Issue or Pull Request #${num} from ${repo} on ${this.name}`,
	});
	} while (true);
	},
	},
	];
	}
	return this._autolinks;
	}

[felipecrs]

@eamodio Thanks for the heads up. This is really cool and I could definitely make use of it to fix the Gerrit specific issue.

However, it would be even nicer if we could get the Support user-defined regex for auto-links as we could solve many issues at once, including this one for Gerrit.