Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink fails with curly braces #2380

Closed
JordanLongstaff opened this issue Nov 30, 2022 · 3 comments
Closed

Autolink fails with curly braces #2380

JordanLongstaff opened this issue Nov 30, 2022 · 3 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@JordanLongstaff
Copy link

JordanLongstaff commented Nov 30, 2022

Description

This is one of the autolinks in my settings:

Screenshot 2022-11-30 at 11 33 23 AM

I made a commit to show how well autolinks work with various brackets, parentheses etc. One of these things is not like the others!

Screenshot 2022-11-30 at 11 33 05 AM

This is important because source control for my repository is managed through Phabricator and wrapping tickets in curly braces is common. For files, it inlines them in the commit summary in Phabricator. But it breaks the autolinks in GitLens.

GitLens Version

13.1.1

VS Code Version

Version: 1.73.1 (Universal)
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T02:08:38.961Z (3 wks ago)
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No

Git Version

git version 2.34.0

Logs, Screenshots, Screen Captures, etc

See above.

@JordanLongstaff JordanLongstaff added potential-bug triage Needs to be looked at labels Nov 30, 2022
@eamodio eamodio self-assigned this Dec 6, 2022
@eamodio eamodio closed this as completed in f2e5d48 Dec 6, 2022
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Dec 6, 2022
@eamodio eamodio added this to the 13.2 milestone Dec 6, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Dec 6, 2022
@eamodio
Copy link
Member

eamodio commented Dec 6, 2022

Can you please verify this fix in tomorrow's pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@JordanLongstaff
Copy link
Author

It works, thank you!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification labels Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

2 participants