Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support search and open file history change #2641

Closed
tjx666 opened this issue Apr 17, 2023 · 10 comments · Fixed by #2800
Closed

[Feature] Support search and open file history change #2641

tjx666 opened this issue Apr 17, 2023 · 10 comments · Fixed by #2800
Assignees
@eamodio
Labels
feature New feature or request good first issue Good for newcomers verified ✔ Verified
Milestone
14.3

Comments

@tjx666
Copy link

tjx666 commented Apr 17, 2023

image
@tjx666 tjx666 added feature New feature or request triage Needs to be looked at labels Apr 17, 2023
@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Apr 27, 2023
@eamodio
Copy link
Member

eamodio commented Apr 27, 2023

Not sure I understand the ask here. Are you asking to jump to the File History view from the Command Palette? If so:

image

@tjx666
Copy link
Author

tjx666 commented Apr 28, 2023

No, my meaning is to provide a history search picker, not jump to the view. @eamodio

@eamodio
Copy link
Member

eamodio commented Apr 28, 2023

The history picker is the first option in the image above. The latter two options are the views.

@tjx666
Copy link
Author

tjx666 commented Apr 28, 2023

What is the difference between GitLens: Quick Open File History and GitLens: Show File History?

image

@tjx666
Copy link
Author

tjx666 commented Apr 28, 2023

I hope here can provide a button to open the change:

image

@eamodio
Copy link
Member

eamodio commented May 1, 2023 •
edited

What is the difference between GitLens: Quick Open File History and GitLens: Show File History?

They do the same thing -- just alternate searches. The latter existed before GitLens had a File History view, and the former was added later to be clearer in the menus.

I hope here can provide a button to open the change:

So you don't have click on an item and then choose?

image

@tjx666
Copy link
Author

tjx666 commented May 2, 2023

@eamodio yes

@eamodio eamodio removed the needs-more-info Needs further information, steps, details, etc. label May 2, 2023
@eamodio eamodio added this to the Backlog milestone May 2, 2023
@eamodio eamodio added the good first issue Good for newcomers label May 2, 2023
@omarfesal omarfesal mentioned this issue Jul 7, 2023
Merged
7 tasks
omarfesal pushed a commit to omarfesal/vscode-gitlens that referenced this issue Jul 7, 2023
Fixes gitkraken#2641 Support search and open file history change
5eca70e
eamodio pushed a commit to omarfesal/vscode-gitlens that referenced this issue Aug 11, 2023
@eamodio
Fixes gitkraken#2641 Support search and open file history change
0458123
eamodio added a commit to omarfesal/vscode-gitlens that referenced this issue Aug 11, 2023
@eamodio
Ensures open changes only added to file commits
ecd9a82 
Updates CHANGELOG & README
Refs: gitkraken#2641
eamodio pushed a commit that referenced this issue Aug 11, 2023
@eamodio
Fixes #2641 Support search and open file history change
d2052eb
eamodio added a commit that referenced this issue Aug 11, 2023
@eamodio
Ensures open changes only added to file commits
03f5092 
Updates CHANGELOG & README
Refs: #2641
@eamodio eamodio self-assigned this Aug 11, 2023
@eamodio eamodio modified the milestones: Backlog, 14.3 Aug 11, 2023
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Aug 11, 2023
@eamodio
Copy link
Member

eamodio commented Aug 11, 2023

Can you please verify this fix in tomorrow's (v2023.8.11xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@tjx666
Copy link
Author

tjx666 commented Aug 14, 2023

@eamodio works fine. Thanks

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Aug 14, 2023
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature New feature or request good first issue Good for newcomers verified ✔ Verified
Projects
None yet
Milestone
14.3
Development

Successfully merging a pull request may close this issue.

Fixes #2641 Support search and open file history change omarfesal/vscode-gitlens
2 participants
@eamodio @tjx666