Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor on Uncommitted message #42

Closed
pankajpatel opened this issue Mar 3, 2017 · 20 comments
Closed

Cursor on Uncommitted message #42

pankajpatel opened this issue Mar 3, 2017 · 20 comments
Assignees
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature

Comments

@pankajpatel
Copy link

The cursor position should not be around the uncommitted info on empty line
cursor

@svipas
Copy link

svipas commented Mar 3, 2017

I can confirm this, OS: Linux Ubuntu 16.04, VS Code: 1.10, Git: 2.11.0
Seems it was fixed, @pankajpatel can you confirm this after GitLens extension update?

@eamodio
Copy link
Member

eamodio commented Mar 3, 2017

@pankajpatel as @svipben mentioned this should be fixed in a later version of GitLens. Please let me know if you are still seeing issues on the latest version (currently 2.9.0).

@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label Mar 3, 2017
@pankajpatel
Copy link
Author

Sorry for less info;

OS: macOS Sierra v10.12.3 (16D32)
VSCode: Version 1.10.1 (1.10.1)
GitLens: v2.9.0

Issue is still visible.
screen shot 2017-03-03 at 4 48 20 pm

@svipas
Copy link

svipas commented Mar 3, 2017

Right now I can confirm it too.

Image

@eamodio
Copy link
Member

eamodio commented Mar 3, 2017

@pankajpatel @svipben How do you get into that state? What are the steps?

eamodio added a commit that referenced this issue Mar 3, 2017
@eamodio
Copy link
Member

eamodio commented Mar 3, 2017

@pankajpatel @svipben fyi, I pushed an update with a set of fixes, some of which might address this -- please let me know if the issue still persists. Thanks!

@svipas
Copy link

svipas commented Mar 3, 2017

I think I know why it happens, try to use tab or space in empty line, it will triggers Uncommited change.

@pankajpatel
Copy link
Author

@svipben correct. And one thing that I noticed is that if the if the setting for rendering whitespace is ste to all i.e. "editor.renderWhitespace": "all" then the issue doesn't come up.

@eamodio
Copy link
Member

eamodio commented Mar 3, 2017

@pankajpatel ah - that explains why I don't see it. Thanks for the information!

@eamodio
Copy link
Member

eamodio commented Mar 5, 2017

@pankajpatel @svipben Thanks for all the information. This appears to be a vscode bug (as nothing I could think of had any effect at stopping this behavior). I've opened the following issues to track this: vscode #22018 & vscode #22017

@svipas
Copy link

svipas commented Mar 5, 2017

@eamodio Thank you!
Off topic: can you show how Darwin OS looks like and from where I can download it? I found http://www.puredarwin.org website and I saw screenshots, so it looks like this? Seems old & ugly ;D
I'm using Elementary OS which is based on Ubuntu 16.04, but I like to try new things and I like macOS, which is why I prefer Elementary OS too look like mac :D

@eamodio
Copy link
Member

eamodio commented Mar 5, 2017

np. Darwin OS is what macOS calls itself internally. I'm running macOS Sierra.

@eamodio eamodio self-assigned this Mar 5, 2017
@eamodio eamodio added blocked: vscode Caused by or dependent on a VS Code issue or feature and removed needs-more-info Needs further information, steps, details, etc. labels Mar 5, 2017
@eamodio
Copy link
Member

eamodio commented Mar 9, 2017

Since vscode fixed this issue I'm closing it

@eamodio eamodio closed this as completed Mar 9, 2017
@pankajpatel
Copy link
Author

I also noticed the smooth working after updating the VSCode. Thankyou!

@pankajpatel
Copy link
Author

This issue is reappearing again. can we reopen it?

@eamodio
Copy link
Member

eamodio commented Mar 16, 2017

@pankajpatel you are still running the insiders build of vscode? If so is it the same scenario?

@pankajpatel
Copy link
Author

pankajpatel commented Mar 16, 2017

I am sunning the stable version and the scenario was similar. It happens when there are spaces in the line.
VSCOde: Version 1.10.2 (1.10.2)
GitLens: 2.12.2

error

@svipas
Copy link

svipas commented Mar 16, 2017

@pankajpatel it wasn't fixed on stable, it was fixed in insiders build as @eamodio said. I didn't tested, just waiting for stable release 😄 Try to download insiders build or wait for new stable release with fixes.

@eamodio
Copy link
Member

eamodio commented Mar 16, 2017

@pankajpatel as @svipben mentioned the vscode fix will be in the next version (1.11) or the current insiders build.

billsedison added a commit to noside911/vscode-gitlens that referenced this issue Jan 4, 2019
@github-actions
Copy link

github-actions bot commented Dec 9, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature
Projects
None yet
Development

No branches or pull requests

3 participants