-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display extra gitlens in vue file with vetur #50
Comments
@beeplin this is by design -- GitLens uses the symbol information provided by vscode to add its CodeLens (and extensions can extend/provide this symbol information). So the Vue extension must be providing a symbol for those classes. You can control the behavior of the CodeLens via a few GitLens configuration settings (you can find the documentation for each setting here: https://github.com/eamodio/vscode-gitlens#extension-settings):
If you have any of the above set, please let me know how you have them configured. Also if you upgrade to v2.12.1, you can also set |
thanks. I will feedback to the author of vetur. |
Hey I'm working on vetur. VSCode added symbols for html/css in Feb release: https://code.visualstudio.com/updates/v1_10#_html If this breaks for vetur, it must be breaking for html too. @beeplin Would you mind setting |
@octref sorry -- I definitely wasn't suggesting anything was wrong in vetur -- nor do I consider this something "broken" in GitLens. GitLens allows you to configure the CodeLens how ever you want given enough provided symbols from vscode/extensions. But since @octref what is the language type for vue? |
@beeplin can you try the following setting:
And let me know if that resolves the issue for you? If so, then I will add those into the defaults for the next release. |
@eamodio thanks for the quick response! Yes, this setting resolve my issue perfectly. |
@beeplin great -- look for that to be in the defaults of the next release and you'll be able to remove those explicit settings |
@beeplin it's now in 2.12.2 |
Thanks a lot. gitlens looks pretty useful. I'll give it a try this weekend. |
…letters Fix missing last letter gitkraken#48
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When working together with vetur (vscode's officially recommended vue plugin) vuejs/vetur#87, .vue files <style> part has extra gitlens displays:
If using other vue support plugins such as
vue
orvue-component
there is no this issue. Simply renaming .vue file to .html file doesn't show the extra gitlens either. This happens only with vetur.The text was updated successfully, but these errors were encountered: