Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLens not working against PR review files #678

Closed
fabrik42 opened this issue Mar 9, 2019 · 2 comments
Closed

GitLens not working against PR review files #678

fabrik42 opened this issue Mar 9, 2019 · 2 comments
Assignees
@eamodio
Labels
feature New feature or request

Comments

@fabrik42
Copy link

fabrik42 commented Mar 9, 2019

As a follow-up to this tweet:

When reviewing changes using the official GitHub pull request extension it would be nice to use the features of GitLens either within the review/diff mode of the pull request extension or a quick way (shortcut?) to open a PR review file in a way that it can be used with the GitLens extension.

For code reviewing the combination of both whould be a powerful tool!
@eamodio eamodio added the feature New feature or request label Apr 1, 2019
@eamodio eamodio added this to the Soonish™ milestone Sep 26, 2019
@eamodio eamodio self-assigned this Sep 26, 2019
@eamodio eamodio modified the milestones: Soonish™, Soon™ Sep 28, 2019
@eamodio eamodio closed this as completed in 7980fff Oct 6, 2019
@eamodio eamodio removed this from the Soon™ milestone Oct 6, 2019
@fabrik42
Copy link
Author

fabrik42 commented Oct 6, 2019

Thanks! 🎉

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabrik42 @eamodio