Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2791 changes to fix contributors link in readme #2792

Merged
merged 2 commits into from Jul 9, 2023

Conversation

leo9-py
Copy link
Contributor

@leo9-py leo9-py commented Jul 4, 2023

Fixes #2791

Description

While looking into the repo's readme I found that the contributors link was non functional. In my testing it would appear that removing the two emojis at the end of the contributors link allows the link to gain it's intended functionality while not changing anything else about the page.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio merged commit dfea6e7 into gitkraken:main Jul 9, 2023
1 check passed
@eamodio
Copy link
Member

eamodio commented Jul 9, 2023

Thank you for your contribution!

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use contributors link in README.md
2 participants