-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for application settings #120
Comments
I don't have an actual need for this, but having this present allows to configure most of the gitlab with infrastructure as code approach, mostly for on-premise installations. otoh, for on-premise installations some of the settings can be controlled via ominbus configuration, but seems the settings configurable via this API are not configurable via omnibus config, see the gitlab.rb.template for the list. |
This feature is already nicely implemented in the „gitlab-configuration-as-code” project and mostly because of that I proposed Roche/gitlab-configuration-as-code#9 . We should get back to discussing it. |
oh, I really like the |
Unfortunately Roche/gitlab-configuration-as-code#9 has stalled so we are open to PRs with this feature. The API is really simple here - https://docs.gitlab.com/ee/api/settings.html - so it should be pretty easy. I propose implementing it as a new config section looking like this:
(Then we can easily add support for https://docs.gitlab.com/ee/api/appearance.html later on.) |
We'll likely pick this up @gdubicki as we specifically want to configure 2FA settings through Application Settings config, and probably a lot more too |
- Resolves gitlabform#120 - Uses python-gitlab to modify application settings of a GitLab instance Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Resolves gitlabform#120 - Uses python-gitlab to modify application settings of a GitLab instance Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Resolves gitlabform#120 - Uses python-gitlab to modify application settings of a GitLab instance Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Resolves gitlabform#120 - Uses python-gitlab to modify application settings of a GitLab instance Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
It has finally been implemented and release in v3.10.0 a moment ago. Thanks again, @TimKnight-DWP! 😊 |
- Resolves gitlabform#120 - Uses python-gitlab to modify application settings of a GitLab instance Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Theres
/application/settings
entrypoint to change Application Settings:The text was updated successfully, but these errors were encountered: