Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application settings #120

Closed
glensc opened this issue Jul 8, 2020 · 6 comments · Fixed by #742
Closed

Add support for application settings #120

glensc opened this issue Jul 8, 2020 · 6 comments · Fixed by #742
Assignees

Comments

@glensc
Copy link
Contributor

glensc commented Jul 8, 2020

Theres /application/settings entrypoint to change Application Settings:

@glensc
Copy link
Contributor Author

glensc commented Jul 8, 2020

I don't have an actual need for this, but having this present allows to configure most of the gitlab with infrastructure as code approach, mostly for on-premise installations.

otoh, for on-premise installations some of the settings can be controlled via ominbus configuration, but seems the settings configurable via this API are not configurable via omnibus config, see the gitlab.rb.template for the list.

@gdubicki
Copy link
Member

This feature is already nicely implemented in the „gitlab-configuration-as-code” project and mostly because of that I proposed Roche/gitlab-configuration-as-code#9 . We should get back to discussing it.

@glensc
Copy link
Contributor Author

glensc commented Jul 13, 2020

oh, I really like the !include and !env syntax:

@gdubicki
Copy link
Member

Unfortunately Roche/gitlab-configuration-as-code#9 has stalled so we are open to PRs with this feature.

The API is really simple here - https://docs.gitlab.com/ee/api/settings.html - so it should be pretty easy.

I propose implementing it as a new config section looking like this:

application:
  settings:
    signup_enabled" : false

(Then we can easily add support for https://docs.gitlab.com/ee/api/appearance.html later on.)

@TimKnight-DWP
Copy link
Collaborator

We'll likely pick this up @gdubicki as we specifically want to configure 2FA settings through Application Settings config, and probably a lot more too

@TimKnight-DWP TimKnight-DWP self-assigned this May 1, 2024
TimKnight-DWP added a commit to TimKnight-DWP/gitlabform that referenced this issue May 1, 2024
- Resolves gitlabform#120
- Uses python-gitlab to modify application settings of a GitLab instance

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
TimKnight-DWP added a commit to TimKnight-DWP/gitlabform that referenced this issue May 2, 2024
- Resolves gitlabform#120
- Uses python-gitlab to modify application settings of a GitLab instance

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
TimKnight-DWP added a commit to TimKnight-DWP/gitlabform that referenced this issue May 2, 2024
- Resolves gitlabform#120
- Uses python-gitlab to modify application settings of a GitLab instance

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
TimKnight-DWP added a commit to TimKnight-DWP/gitlabform that referenced this issue May 2, 2024
- Resolves gitlabform#120
- Uses python-gitlab to modify application settings of a GitLab instance

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
@gdubicki
Copy link
Member

gdubicki commented May 5, 2024

It has finally been implemented and release in v3.10.0 a moment ago. Thanks again, @TimKnight-DWP! 😊

mahadevan-karthi-dwp pushed a commit to mahadevan-karthi-dwp/gitlabform that referenced this issue May 9, 2024
- Resolves gitlabform#120
- Uses python-gitlab to modify application settings of a GitLab instance

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants