Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying pipeline schedules is not working #361

Closed
mjuraszek92 opened this issue May 6, 2022 · 7 comments
Closed

Applying pipeline schedules is not working #361

mjuraszek92 opened this issue May 6, 2022 · 7 comments

Comments

@mjuraszek92
Copy link

Describe the bug

Seems that recently there were changes in GitLab that affected current way of applying pipeline schedules.

The flow of applying pipeline schedules is following:

  1. Update pipeline schedule
  2. Take ownership for a schedule

The problem is that currently if a user performing an action is already an owner of the schedule then the point 2 ends up with error:
{"message":"403 Forbidden"}

The behaviour can be easily verified in GitLab by hitting the API two times in a row with the same user token.

GitLabForm version

2.10.1

GitLab version

14.9.4-ee

@jocado
Copy link

jocado commented May 6, 2022

Confirmed here as well: 14.9.4-ee

@jocado
Copy link

jocado commented May 6, 2022

Looking at the changes, perhaps it's related to this one:

https://gitlab.com/gitlab-org/gitlab-foss/blob/master/CHANGELOG.md#14101-2022-04-29

  • Prevent maintainers from editing PipelineSchedule (merge request)

@gdubicki
Copy link
Member

gdubicki commented May 6, 2022

Thanks for reporting!

Probably this is also the reason the tests have failed today in https://github.com/gdubicki/gitlabform/runs/6318302269?check_suite_focus=true ...

gdubicki added a commit that referenced this issue May 6, 2022
This is a temporary workaround for a idempotency bug
in GitLab.

See issue #361.
@gdubicki
Copy link
Member

gdubicki commented May 7, 2022

I have just released v2.11.0b4 with the above workaround. A final release will be done after the weekend.

@gdubicki
Copy link
Member

gdubicki commented May 9, 2022

The workaround is now in a final release v2.11.0.

@gdubicki
Copy link
Member

gdubicki commented May 9, 2022

We should find/report the issue to GitLab. But as I don't think that the workaround will affect anything negatively, I will just close this issue treating the problem as solved.

@gdubicki gdubicki closed this as completed May 9, 2022
@jocado
Copy link

jocado commented May 9, 2022

Thanks or the quick fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants