Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always expect pagination for GETs #358

Merged
merged 1 commit into from Apr 25, 2022
Merged

Always expect pagination for GETs #358

merged 1 commit into from Apr 25, 2022

Conversation

gdubicki
Copy link
Member

as it happened a few times already that we didn't mark an API as using
pagination initially and it caused problems for some users. According
to GitLab's API docs (https://docs.gitlab.com/ee/api/#pagination)
the pagination "is available on all endpoints", so let's just pass
the for all GETs.

Fixes #354.

as it happened a few times already that we didn't mark an API as using
pagination initially and it caused problems for some users. According
to GitLab's API docs (https://docs.gitlab.com/ee/api/#pagination)
the pagination "is available on all endpoints", so let's just pass
the for all GETs.

Fixes #354.
@gdubicki gdubicki marked this pull request as ready for review April 23, 2022 08:12
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #358 (1536d62) into main (20e2644) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          63       63           
  Lines        2433     2433           
=======================================
  Hits         1969     1969           
  Misses        464      464           
Impacted Files Coverage Δ
gitlabform/gitlab/branches.py 86.76% <ø> (ø)
gitlabform/gitlab/merge_requests.py 53.33% <ø> (ø)
gitlabform/gitlab/pipelines.py 45.45% <ø> (ø)
gitlabform/gitlab/projects.py 55.14% <0.00%> (ø)
gitlabform/gitlab/tags.py 100.00% <ø> (ø)
gitlabform/gitlab/core.py 92.36% <100.00%> (ø)
gitlabform/gitlab/groups.py 87.93% <100.00%> (ø)
gitlabform/gitlab/members.py 97.61% <100.00%> (ø)

@gdubicki gdubicki merged commit 23a2d30 into main Apr 25, 2022
@gdubicki gdubicki deleted the fix_354 branch June 4, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems with setting variables which already exist (idempotence) with gitlabform 2.10.1
1 participant