Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 #389

Merged
merged 20 commits into from
Jun 30, 2022
Merged

V3 #389

merged 20 commits into from
Jun 30, 2022

Conversation

gdubicki
Copy link
Member

@gdubicki gdubicki commented Jun 25, 2022

Python 3.6 has been EOLed in Dec 2021 and since then a lot of our dependencies have dropped support for it.

As changing the required Python version to a higher one is a backward-incompatible change I wanted to combine it with the big configuration syntax upgrade described in #331.

However the latter is getting delayed because I can't find enough time to do it (see #343).

That's why I would like to release v3 now which will just require a Python upgrade but not any configuration syntax changes and move the planned configuration syntax change to v4.

Update: the scope of this release has been increased, see the last comments and commits below.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #389 (754109d) into main (b66775b) will increase coverage by 0.05%.
The diff coverage is 85.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   81.00%   81.05%   +0.05%     
==========================================
  Files          63       62       -1     
  Lines        2443     2381      -62     
==========================================
- Hits         1979     1930      -49     
+ Misses        464      451      -13     
Impacted Files Coverage Δ
gitlabform/configuration/core.py 72.35% <0.00%> (ø)
gitlabform/filter.py 100.00% <ø> (ø)
gitlabform/gitlab/projects.py 56.48% <ø> (+1.34%) ⬆️
...orm/processors/project/merge_requests_processor.py 28.57% <ø> (+3.03%) ⬆️
...tlabform/processors/project/variables_processor.py 58.06% <58.06%> (ø)
gitlabform/processors/util/branch_protector.py 73.50% <94.44%> (-1.50%) ⬇️
gitlabform/gitlab/group_variables.py 95.00% <95.00%> (ø)
gitlabform/gitlab/__init__.py 100.00% <100.00%> (ø)
gitlabform/gitlab/branches.py 85.48% <100.00%> (-1.29%) ⬇️
gitlabform/gitlab/integrations.py 100.00% <100.00%> (ø)
... and 6 more

as has 0 downloads over the last 10 days
so it seems to be not used and it generates
unnecessary complexity in the application
image tags.
since Dec 2021 and many dependencies
have already dropped support for it
so we have to do it also.
next to v2 as the syntax has not changed between
v2 and v3.
@gdubicki
Copy link
Member Author

Pre-release created: https://github.com/gitlabform/gitlabform/releases/tag/v3.0.0rc1

@gdubicki
Copy link
Member Author

On second thought (thanks to @jimisola for the inspiration!) maybe we should also do #391.

@gdubicki gdubicki changed the title V3 as a technical upgrade, no new features V3 Jun 29, 2022
@gdubicki gdubicki merged commit f760994 into main Jun 30, 2022
@gdubicki gdubicki deleted the v3 branch June 30, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants