-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 81.00% 81.05% +0.05%
==========================================
Files 63 62 -1
Lines 2443 2381 -62
==========================================
- Hits 1979 1930 -49
+ Misses 464 451 -13
|
as has 0 downloads over the last 10 days so it seems to be not used and it generates unnecessary complexity in the application image tags.
since Dec 2021 and many dependencies have already dropped support for it so we have to do it also.
next to v2 as the syntax has not changed between v2 and v3.
Pre-release created: https://github.com/gitlabform/gitlabform/releases/tag/v3.0.0rc1 |
that was using the old, undocumented anymore API that can stop working in any new GitLab version
as this is called 'integrations' in the API since that version. See https://gitlab.com/gitlab-org/gitlab/-/issues/334500 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 has been EOLed in Dec 2021 and since then a lot of our dependencies have dropped support for it.
As changing the required Python version to a higher one is a backward-incompatible change I wanted to combine it with the big configuration syntax upgrade described in #331.
However the latter is getting delayed because I can't find enough time to do it (see #343).
That's why I would like to release v3 now which will just require a Python upgrade but not any configuration syntax changes and move the planned configuration syntax change to v4.
Update: the scope of this release has been increased, see the last comments and commits below.