Fix running with ALL when using gitlab.com #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and improve behavior in other cases when running as a non-admin. In that case there is no point in trying to get all groups or projects as you need at least Reporter role to change their configuration. Fixes #509
gdubicki
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 84.21% 84.82% +0.61%
==========================================
Files 70 70
Lines 2679 2688 +9
==========================================
+ Hits 2256 2280 +24
+ Misses 423 408 -15
|
gdubicki
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
gdubicki
commented
Mar 13, 2023
| @@ -28,21 +28,10 @@ def process_entity( | |||
| ): | |||
| for processor in self.processors: | |||
| if only_sections == "all" or processor.configuration_name in only_sections: | |||
| try: | |||
There was a problem hiding this comment.
This part of the PR just restores the code before by debugging that accidentally got pushed to main. It's not related with the rest of the PR.
jimisola
reviewed
Mar 14, 2023
You mean
I've so, then I would say yes. I can't come up with a reason why it's not a good concept. |
gdubicki
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and improve behavior in other cases when running as
a non-admin. In that case there is no point in trying
to get all groups or projects as you need at least
Reporter role to change their configuration.
Fixes: #509