Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v3: mention MR approvals syntax change #525

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

weakcamel
Copy link
Contributor

Related to #388 and #263

@weakcamel weakcamel had a problem deploying to Integrate Pull Request March 31, 2023 13:44 — with GitHub Actions Failure
@weakcamel
Copy link
Contributor Author

After a recent Gitlab instance upgrade I finally got around to upgrading Gitlabform too.

While porting the configs I've noticed that the current version doesn't like the approvals_before_merge outside of merge_requests_approval_rules (see below) so I'm proposing to mention this in the upgrade guide.

Processing section 'merge_requests_approvals'
Error: Setting the 'approvals_before_merge' in the 'merge_requests_approvals' sections is not allowed as it is not clear which rule does it apply to. Please set it inside the specific approval rules in the 'merge_requests_approval_rules' section.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #525 (13ae508) into main (9bd5880) will decrease coverage by 3.10%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   82.03%   78.94%   -3.10%     
==========================================
  Files          70       70              
  Lines        2650     2650              
==========================================
- Hits         2174     2092      -82     
- Misses        476      558      +82     

see 12 files with indirect coverage changes

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/code-quality.yml:codeql. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@gdubicki
Copy link
Member

gdubicki commented Apr 1, 2023

Sure, why not. Thanks for the contribution, @weakcamel!

@gdubicki gdubicki merged commit f91b620 into main Apr 1, 2023
19 of 20 checks passed
@gdubicki gdubicki deleted the upgrade_v3_docs_mr_approvals branch April 1, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants