Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): drop support for python 3.7 #592

Merged
merged 1 commit into from
Aug 25, 2023
Merged

chore(python): drop support for python 3.7 #592

merged 1 commit into from
Aug 25, 2023

Conversation

amimas
Copy link
Collaborator

@amimas amimas commented Aug 24, 2023

Python 3.7 has reached EOL (end of life) as of June 2023. See status of python versions. We're already unable to update some of our dependencies as they have also dropped support for python 3.7. For example: #588, #591

This PR drops support for Python 3.7 by gitlabform.

closes #576

@amimas amimas requested a review from gdubicki August 24, 2023 03:03
@amimas amimas temporarily deployed to Integrate Pull Request August 24, 2023 03:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #592 (b269927) into main (144d369) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   83.29%   83.17%   -0.12%     
==========================================
  Files          70       70              
  Lines        2699     2699              
==========================================
- Hits         2248     2245       -3     
- Misses        451      454       +3     

see 3 files with indirect coverage changes

Copy link
Member

@gdubicki gdubicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amimas amimas merged commit 78c4151 into main Aug 25, 2023
22 of 25 checks passed
@amimas amimas deleted the issue-576 branch August 25, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for python 3.7 and possibly other older versions
2 participants