refactor: migrate project:archive feature to use python-gitlab library #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the Gitlab object created from GitlabWrapper to the AbstractProcessor class so that the object is available to all other processors. Then updated project processor code to use the Gitlab object, which comes from the python-gitlab library, for performing project archive and unarchive. Removed the internal API/method that was previously used for calling the GitLab's API for project archive and unarchive purpose.
…ab from AbstractProcessor
amimas
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 83.50% 83.63% +0.13%
==========================================
Files 70 70
Lines 2746 2744 -2
==========================================
+ Hits 2293 2295 +2
+ Misses 453 449 -4
|
amimas
commented
Oct 26, 2023
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
gdubicki
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #582 that provided the setup to use
python-gitlablibrary. Refactored theproject:archivefeature's implementation to use thepython-gitlablibrary instead of internal methods that called GitLab's API endpoint.closes #621