feat: add enforce support for project hooks/webhooks configuration
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If enforce==true in hooks config all non present hooks are deleted
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 84.27% 84.41% +0.14%
==========================================
Files 69 69
Lines 2741 2747 +6
==========================================
+ Hits 2310 2319 +9
+ Misses 431 428 -3
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
requested changes
Jan 7, 2024
There was a problem hiding this comment.
Do we need an additional test case when hooks delete amd enforce is used together? I guess the existing test case named test_hooks_delete kind of takes care of delete with enforce disabled. What happens delete for a hook is enabled and enforce is also enabled?
amimas
changed the title
enforce support for project hooks/webhooks configuration
Co-authored-by: amimas <aver.mimas@gmail.com>
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Bug fix: iterator config_hooks to tuple (got consumed before 'enforce' section)
…orm into #662_enforce_hooks
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
requested changes
Jan 8, 2024
Co-authored-by: amimas <aver.mimas@gmail.com>
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Co-authored-by: amimas <aver.mimas@gmail.com>
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
In test_hooks, changed string split to group.path
TigreModerata
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'enforce' support for hooks processor. If set to true, all hooks not present in config yaml will be removed. Set to false is the same as omitting it - in this case 'delete: true' has to be set on any hook that should be deleted.
Added 2 tests, enforce to true/false.
Updated documentation section on webhooks.
Closes #662