Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hooks processing fails when config includes token #693

Merged
merged 13 commits into from
Mar 2, 2024
Merged

fix: hooks processing fails when config includes token #693

merged 13 commits into from
Mar 2, 2024

Commits on Feb 28, 2024

  1. test: minor formatting update and import ProjectHook

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fe958bc View commit details
    Browse the repository at this point in the history

  2. test: reproduce issue gitlabform#685

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    855b437 View commit details
    Browse the repository at this point in the history

  3. refactor: rename variables in hooks processor for clarity

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6b16f47 View commit details
    Browse the repository at this point in the history

  4. fix: hook config with token should be updated successfully

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b281ca1 View commit details
    Browse the repository at this point in the history

  5. test: add another hook with token in test cases

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c3f3a40 View commit details
    Browse the repository at this point in the history

  6. test: add comments on test assertion for clarity and fix one of the a… 

    …ssertion
    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d1fdc70 View commit details
    Browse the repository at this point in the history

  7. chore: rename a variable and address mypy type checking issue

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ad9c404 View commit details
    Browse the repository at this point in the history

  8. style: reformat by black

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8ce2a8e View commit details
    Browse the repository at this point in the history

  9. refactor: simplify logic to avoid nested if-else and add test for non… 

    …-existent hook deletion
    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3733e78 View commit details
    Browse the repository at this point in the history

  10. style: update formatting using black

    @amimas
    amimas committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3ab81d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. refactor: no need for setting token to empty value

    @amimas
    amimas committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    365a264 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. style: simplify if-else code using python style syntax

    @amimas
    amimas committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    258d23e View commit details
    Browse the repository at this point in the history

  2. refactor: use existing logic from super class to check if hook update… 

    … is needed
    @amimas
    amimas committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    f50a044 View commit details
    Browse the repository at this point in the history