refactor: migrate schedules_processor to use python-gitlab

[TimKnight-Opencast]

• closes Migrate schedules configuration feature to use python-gitlab library #631

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (f7c5922) to head (fc4e40a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   85.38%   85.59%   +0.21%     
==========================================
  Files          70       69       -1     
  Lines        2784     2770      -14     
==========================================
- Hits         2377     2371       -6     
+ Misses        407      399       -8     

Files	Coverage Δ
gitlabform/gitlab/__init__.py	100.00% <ø> (ø)
...tlabform/processors/project/schedules_processor.py	98.80% <100.00%> (+4.96%)	⬆️

... and 1 file with indirect coverage changes

[amimas]

Thanks for this PR @TimKnight-Opencast . Based on PR description and file changes, it seems branch protection processor is also included. Really appreciate the help converting both schedule processor and branch protection processor. But, it's a lot easier to review and safer if we keep the scope of changes to minimum. Could you please open a separate PR for branch protection processor related changes?

[TimKnight-Opencast]

@amimas done I've cut a new branch for branch_processor changes.

Will raise a PR once the group_members refactor is in so can re-use the common python-gitlab code I'm adding in there

[TimKnight-Opencast]

(same person, I just work for a consultancy at DWP, and due to stuff, needed to contribute from this account instead last week 😸 )

[amimas]

It mostly looks good to me. Thanks for taking care of this. Only major issue I see is how the schedule is being created/updated.

[TimKnight-Opencast]

@amimas - reverted the test changes so it's just a subset using project_for_function (i.e. my new tests) and added that test for validating the logs when no changes to an existing schedule are made

[amimas]

Thanks for all the work on this ❤️ . I've re-opened a conversation that I think is not resolved yet and it will likely introduce bug. Otherwise it looks good to merge.

[amimas]

Looks good to me. Thanks again for all the work.